chore: junitxml tests: introduce more typesafe helpers

This commit is contained in:
Ronny Pfannschmidt 2024-02-21 16:29:45 +01:00
parent e133932b7b
commit 71a2add68d
1 changed files with 130 additions and 121 deletions

View File

@ -108,10 +108,14 @@ class DomNode:
t = type(self)
return [t(x) for x in self.__node.getElementsByTagName(tag)]
def __getitem__(self, key):
def __getitem__(self, key: str) -> str:
if isinstance(self.__node, minidom.Document):
raise TypeError(type(self.__node))
node = self.__node.getAttributeNode(key)
if node is not None:
return node.value
return cast(str, node.value)
else:
raise KeyError(key)
def assert_attr(self, **kwargs: object) -> None:
__tracebackhide__ = True
@ -134,6 +138,13 @@ class DomNode:
def next_sibling(self) -> DomNode:
return type(self)(self.__node.nextSibling)
def get_first_by_tag(self, tag: str) -> DomNode:
maybe = self.find_first_by_tag(tag)
if maybe is None:
raise LookupError(tag)
else:
return maybe
parametrize_families = pytest.mark.parametrize("xunit_family", ["xunit1", "xunit2"])
@ -162,7 +173,7 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(name="pytest", errors=0, failures=1, skipped=2, tests=5)
@parametrize_families
@ -191,7 +202,7 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(name="pytest", errors=1, failures=2, skipped=1, tests=5)
@parametrize_families
@ -205,7 +216,7 @@ class TestPython:
"""
)
result, dom = run_and_parse(family=xunit_family)
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(hostname=platform.node())
@parametrize_families
@ -220,7 +231,7 @@ class TestPython:
)
start_time = datetime.now()
result, dom = run_and_parse(family=xunit_family)
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
timestamp = datetime.strptime(node["timestamp"], "%Y-%m-%dT%H:%M:%S.%f")
assert start_time <= timestamp < datetime.now()
@ -242,9 +253,10 @@ class TestPython:
"""
)
result, dom = run_and_parse()
node = dom.find_first_by_tag("testsuite")
tnode = node.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testsuite")
tnode = node.get_first_by_tag("testcase")
val = tnode["time"]
assert val is not None
assert float(val) == 7.0
@pytest.mark.parametrize("duration_report", ["call", "total"])
@ -272,8 +284,8 @@ class TestPython:
"""
)
result, dom = run_and_parse("-o", f"junit_duration_report={duration_report}")
node = dom.find_first_by_tag("testsuite")
tnode = node.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testsuite")
tnode = node.get_first_by_tag("testcase")
val = float(tnode["time"])
if duration_report == "total":
assert val == 3.0
@ -298,11 +310,11 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(errors=1, tests=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(classname="test_setup_error", name="test_function")
fnode = tnode.find_first_by_tag("error")
fnode = tnode.get_first_by_tag("error")
fnode.assert_attr(message='failed on setup with "ValueError: Error reason"')
assert "ValueError" in fnode.toxml()
@ -324,10 +336,10 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret
node = dom.find_first_by_tag("testsuite")
tnode = node.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testsuite")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(classname="test_teardown_error", name="test_function")
fnode = tnode.find_first_by_tag("error")
fnode = tnode.get_first_by_tag("error")
fnode.assert_attr(message='failed on teardown with "ValueError: Error reason"')
assert "ValueError" in fnode.toxml()
@ -349,15 +361,15 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(errors=1, failures=1, tests=1)
first, second = dom.find_by_tag("testcase")
assert first
assert second
assert first != second
fnode = first.find_first_by_tag("failure")
fnode = first.get_first_by_tag("failure")
fnode.assert_attr(message="Exception: Call Exception")
snode = second.find_first_by_tag("error")
snode = second.get_first_by_tag("error")
snode.assert_attr(
message='failed on teardown with "Exception: Teardown Exception"'
)
@ -375,11 +387,11 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret == 0
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(skipped=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(classname="test_skip_contains_name_reason", name="test_skip")
snode = tnode.find_first_by_tag("skipped")
snode = tnode.get_first_by_tag("skipped")
snode.assert_attr(type="pytest.skip", message="hello23")
@parametrize_families
@ -396,13 +408,13 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret == 0
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(skipped=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(
classname="test_mark_skip_contains_name_reason", name="test_skip"
)
snode = tnode.find_first_by_tag("skipped")
snode = tnode.get_first_by_tag("skipped")
snode.assert_attr(type="pytest.skip", message="hello24")
@parametrize_families
@ -420,13 +432,13 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret == 0
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(skipped=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(
classname="test_mark_skipif_contains_name_reason", name="test_skip"
)
snode = tnode.find_first_by_tag("skipped")
snode = tnode.get_first_by_tag("skipped")
snode.assert_attr(type="pytest.skip", message="hello25")
@parametrize_families
@ -443,7 +455,7 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret == 0
node_xml = dom.find_first_by_tag("testsuite").toxml()
node_xml = dom.get_first_by_tag("testsuite").toxml()
assert "bar!" not in node_xml
@parametrize_families
@ -459,9 +471,9 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(failures=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(
classname="test_classname_instance.TestClass", name="test_method"
)
@ -474,9 +486,9 @@ class TestPython:
p.write_text("def test_func(): 0/0", encoding="utf-8")
result, dom = run_and_parse(family=xunit_family)
assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(failures=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(classname="sub.test_hello", name="test_func")
@parametrize_families
@ -487,11 +499,11 @@ class TestPython:
pytester.makepyfile("def test_function(): pass")
result, dom = run_and_parse(family=xunit_family)
assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(errors=1, tests=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(classname="pytest", name="internal")
fnode = tnode.find_first_by_tag("error")
fnode = tnode.get_first_by_tag("error")
fnode.assert_attr(message="internal error")
assert "Division" in fnode.toxml()
@ -524,22 +536,22 @@ class TestPython:
"-o", f"junit_logging={junit_logging}", family=xunit_family
)
assert result.ret, "Expected ret > 0"
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(failures=1, tests=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(classname="test_failure_function", name="test_fail")
fnode = tnode.find_first_by_tag("failure")
fnode = tnode.get_first_by_tag("failure")
fnode.assert_attr(message="ValueError: 42")
assert "ValueError" in fnode.toxml(), "ValueError not included"
if junit_logging in ["log", "all"]:
logdata = tnode.find_first_by_tag("system-out")
logdata = tnode.get_first_by_tag("system-out")
log_xml = logdata.toxml()
assert logdata.tag == "system-out", "Expected tag: system-out"
assert "info msg" not in log_xml, "Unexpected INFO message"
assert "warning msg" in log_xml, "Missing WARN message"
if junit_logging in ["system-out", "out-err", "all"]:
systemout = tnode.find_first_by_tag("system-out")
systemout = tnode.get_first_by_tag("system-out")
systemout_xml = systemout.toxml()
assert systemout.tag == "system-out", "Expected tag: system-out"
assert "info msg" not in systemout_xml, "INFO message found in system-out"
@ -547,7 +559,7 @@ class TestPython:
"hello-stdout" in systemout_xml
), "Missing 'hello-stdout' in system-out"
if junit_logging in ["system-err", "out-err", "all"]:
systemerr = tnode.find_first_by_tag("system-err")
systemerr = tnode.get_first_by_tag("system-err")
systemerr_xml = systemerr.toxml()
assert systemerr.tag == "system-err", "Expected tag: system-err"
assert "info msg" not in systemerr_xml, "INFO message found in system-err"
@ -578,9 +590,9 @@ class TestPython:
"""
)
result, dom = run_and_parse(family=xunit_family)
node = dom.find_first_by_tag("testsuite")
tnode = node.find_first_by_tag("testcase")
fnode = tnode.find_first_by_tag("failure")
node = dom.get_first_by_tag("testsuite")
tnode = node.get_first_by_tag("testcase")
fnode = tnode.get_first_by_tag("failure")
fnode.assert_attr(message="AssertionError: An error\nassert 0")
@parametrize_families
@ -600,7 +612,7 @@ class TestPython:
"-o", "junit_logging=system-out", family=xunit_family
)
assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(failures=3, tests=3)
tnodes = node.find_by_tag("testcase")
assert len(tnodes) == 3
@ -608,7 +620,7 @@ class TestPython:
tnode.assert_attr(
classname="test_failure_escape", name=f"test_func[{char}]"
)
sysout = tnode.find_first_by_tag("system-out")
sysout = tnode.get_first_by_tag("system-out")
text = sysout.text
assert f"{char}\n" in text
@ -627,11 +639,11 @@ class TestPython:
)
result, dom = run_and_parse("--junitprefix=xyz", family=xunit_family)
assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(failures=1, tests=2)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(classname="xyz.test_junit_prefixing", name="test_func")
tnode = node.find_nth_by_tag("testcase", 1)
tnode = node.find_by_tag("testcase")[1]
tnode.assert_attr(
classname="xyz.test_junit_prefixing.TestHello", name="test_hello"
)
@ -649,11 +661,11 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
assert not result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(skipped=1, tests=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(classname="test_xfailure_function", name="test_xfail")
fnode = tnode.find_first_by_tag("skipped")
fnode = tnode.get_first_by_tag("skipped")
fnode.assert_attr(type="pytest.xfail", message="42")
@parametrize_families
@ -670,11 +682,11 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
assert not result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(skipped=1, tests=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(classname="test_xfailure_marker", name="test_xfail")
fnode = tnode.find_first_by_tag("skipped")
fnode = tnode.get_first_by_tag("skipped")
fnode.assert_attr(type="pytest.xfail", message="42")
@pytest.mark.parametrize(
@ -696,17 +708,13 @@ class TestPython:
"""
)
result, dom = run_and_parse("-o", f"junit_logging={junit_logging}")
node = dom.find_first_by_tag("testsuite")
tnode = node.find_first_by_tag("testcase")
if junit_logging in ["system-err", "out-err", "all"]:
assert len(tnode.find_by_tag("system-err")) == 1
else:
assert len(tnode.find_by_tag("system-err")) == 0
node = dom.get_first_by_tag("testsuite")
tnode = node.get_first_by_tag("testcase")
if junit_logging in ["log", "system-out", "out-err", "all"]:
assert len(tnode.find_by_tag("system-out")) == 1
else:
assert len(tnode.find_by_tag("system-out")) == 0
has_logging = junit_logging in ["system-err", "out-err", "all"]
expected_output_len = 1 if has_logging else 0
print(tnode)
assert len(tnode.find_by_tag("system-err")) == expected_output_len
@parametrize_families
def test_xfailure_xpass(
@ -722,9 +730,9 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
# assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(skipped=0, tests=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(classname="test_xfailure_xpass", name="test_xpass")
@parametrize_families
@ -741,11 +749,11 @@ class TestPython:
)
result, dom = run_and_parse(family=xunit_family)
# assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(skipped=0, tests=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(classname="test_xfailure_xpass_strict", name="test_xpass")
fnode = tnode.find_first_by_tag("failure")
fnode = tnode.get_first_by_tag("failure")
fnode.assert_attr(message="[XPASS(strict)] This needs to fail!")
@parametrize_families
@ -755,10 +763,10 @@ class TestPython:
pytester.makepyfile("syntax error")
result, dom = run_and_parse(family=xunit_family)
assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(errors=1, tests=1)
tnode = node.find_first_by_tag("testcase")
fnode = tnode.find_first_by_tag("error")
tnode = node.get_first_by_tag("testcase")
fnode = tnode.get_first_by_tag("error")
fnode.assert_attr(message="collection failure")
assert "SyntaxError" in fnode.toxml()
@ -774,8 +782,8 @@ class TestPython:
)
result, dom = run_and_parse()
assert result.ret == 1
tnode = dom.find_first_by_tag("testcase")
fnode = tnode.find_first_by_tag("failure")
tnode = dom.get_first_by_tag("testcase")
fnode = tnode.get_first_by_tag("failure")
assert "hx" in fnode.toxml()
def test_assertion_binchars(
@ -806,14 +814,14 @@ class TestPython:
"""
)
result, dom = run_and_parse("-o", f"junit_logging={junit_logging}")
node = dom.find_first_by_tag("testsuite")
pnode = node.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testsuite")
pnode = node.get_first_by_tag("testcase")
if junit_logging == "no":
assert not node.find_by_tag(
"system-out"
), "system-out should not be generated"
if junit_logging == "system-out":
systemout = pnode.find_first_by_tag("system-out")
systemout = pnode.get_first_by_tag("system-out")
assert (
"hello-stdout" in systemout.toxml()
), "'hello-stdout' should be in system-out"
@ -830,14 +838,14 @@ class TestPython:
"""
)
result, dom = run_and_parse("-o", f"junit_logging={junit_logging}")
node = dom.find_first_by_tag("testsuite")
pnode = node.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testsuite")
pnode = node.get_first_by_tag("testcase")
if junit_logging == "no":
assert not node.find_by_tag(
"system-err"
), "system-err should not be generated"
if junit_logging == "system-err":
systemerr = pnode.find_first_by_tag("system-err")
systemerr = pnode.get_first_by_tag("system-err")
assert (
"hello-stderr" in systemerr.toxml()
), "'hello-stderr' should be in system-err"
@ -859,14 +867,14 @@ class TestPython:
"""
)
result, dom = run_and_parse("-o", f"junit_logging={junit_logging}")
node = dom.find_first_by_tag("testsuite")
pnode = node.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testsuite")
pnode = node.get_first_by_tag("testcase")
if junit_logging == "no":
assert not node.find_by_tag(
"system-out"
), "system-out should not be generated"
if junit_logging == "system-out":
systemout = pnode.find_first_by_tag("system-out")
systemout = pnode.get_first_by_tag("system-out")
assert (
"hello-stdout" in systemout.toxml()
), "'hello-stdout' should be in system-out"
@ -889,14 +897,14 @@ class TestPython:
"""
)
result, dom = run_and_parse("-o", f"junit_logging={junit_logging}")
node = dom.find_first_by_tag("testsuite")
pnode = node.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testsuite")
pnode = node.get_first_by_tag("testcase")
if junit_logging == "no":
assert not node.find_by_tag(
"system-err"
), "system-err should not be generated"
if junit_logging == "system-err":
systemerr = pnode.find_first_by_tag("system-err")
systemerr = pnode.get_first_by_tag("system-err")
assert (
"hello-stderr" in systemerr.toxml()
), "'hello-stderr' should be in system-err"
@ -920,14 +928,14 @@ class TestPython:
"""
)
result, dom = run_and_parse("-o", f"junit_logging={junit_logging}")
node = dom.find_first_by_tag("testsuite")
pnode = node.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testsuite")
pnode = node.get_first_by_tag("testcase")
if junit_logging == "no":
assert not node.find_by_tag(
"system-out"
), "system-out should not be generated"
if junit_logging == "system-out":
systemout = pnode.find_first_by_tag("system-out")
systemout = pnode.get_first_by_tag("system-out")
assert "hello-stdout call" in systemout.toxml()
assert "hello-stdout teardown" in systemout.toxml()
@ -991,11 +999,11 @@ class TestNonPython:
pytester.path.joinpath("myfile.xyz").write_text("hello", encoding="utf-8")
result, dom = run_and_parse(family=xunit_family)
assert result.ret
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(errors=0, failures=1, skipped=0, tests=1)
tnode = node.find_first_by_tag("testcase")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(name="myfile.xyz")
fnode = tnode.find_first_by_tag("failure")
fnode = tnode.get_first_by_tag("failure")
fnode.assert_attr(message="custom item runtest failed")
assert "custom item runtest failed" in fnode.toxml()
@ -1136,7 +1144,7 @@ def test_escaped_parametrized_names_xml(
)
result, dom = run_and_parse()
assert result.ret == 0
node = dom.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testcase")
node.assert_attr(name="test_func[\\x00]")
@ -1153,7 +1161,7 @@ def test_double_colon_split_function_issue469(
)
result, dom = run_and_parse()
assert result.ret == 0
node = dom.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testcase")
node.assert_attr(classname="test_double_colon_split_function_issue469")
node.assert_attr(name="test_func[double::colon]")
@ -1172,7 +1180,7 @@ def test_double_colon_split_method_issue469(
)
result, dom = run_and_parse()
assert result.ret == 0
node = dom.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testcase")
node.assert_attr(classname="test_double_colon_split_method_issue469.TestClass")
node.assert_attr(name="test_func[double::colon]")
@ -1220,9 +1228,9 @@ def test_record_property(pytester: Pytester, run_and_parse: RunAndParse) -> None
"""
)
result, dom = run_and_parse()
node = dom.find_first_by_tag("testsuite")
tnode = node.find_first_by_tag("testcase")
psnode = tnode.find_first_by_tag("properties")
node = dom.get_first_by_tag("testsuite")
tnode = node.get_first_by_tag("testcase")
psnode = tnode.get_first_by_tag("properties")
pnodes = psnode.find_by_tag("property")
pnodes[0].assert_attr(name="bar", value="1")
pnodes[1].assert_attr(name="foo", value="<1")
@ -1248,10 +1256,10 @@ def test_record_property_on_test_and_teardown_failure(
"""
)
result, dom = run_and_parse()
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
tnodes = node.find_by_tag("testcase")
for tnode in tnodes:
psnode = tnode.find_first_by_tag("properties")
psnode = tnode.get_first_by_tag("properties")
assert psnode, f"testcase didn't had expected properties:\n{tnode}"
pnodes = psnode.find_by_tag("property")
pnodes[0].assert_attr(name="bar", value="1")
@ -1270,9 +1278,9 @@ def test_record_property_same_name(
"""
)
result, dom = run_and_parse()
node = dom.find_first_by_tag("testsuite")
tnode = node.find_first_by_tag("testcase")
psnode = tnode.find_first_by_tag("properties")
node = dom.get_first_by_tag("testsuite")
tnode = node.get_first_by_tag("testcase")
psnode = tnode.get_first_by_tag("properties")
pnodes = psnode.find_by_tag("property")
pnodes[0].assert_attr(name="foo", value="bar")
pnodes[1].assert_attr(name="foo", value="baz")
@ -1312,8 +1320,8 @@ def test_record_attribute(pytester: Pytester, run_and_parse: RunAndParse) -> Non
"""
)
result, dom = run_and_parse()
node = dom.find_first_by_tag("testsuite")
tnode = node.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testsuite")
tnode = node.get_first_by_tag("testcase")
tnode.assert_attr(bar="1")
tnode.assert_attr(foo="<1")
result.stdout.fnmatch_lines(
@ -1375,7 +1383,7 @@ def test_random_report_log_xdist(
"""
)
_, dom = run_and_parse("-n2")
suite_node = dom.find_first_by_tag("testsuite")
suite_node = dom.get_first_by_tag("testsuite")
failed = []
for case_node in suite_node.find_by_tag("testcase"):
if case_node.find_first_by_tag("failure"):
@ -1566,10 +1574,11 @@ def test_record_testsuite_property(
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret == 0
node = dom.find_first_by_tag("testsuite")
properties_node = node.find_first_by_tag("properties")
p1_node = properties_node.find_nth_by_tag("property", 0)
p2_node = properties_node.find_nth_by_tag("property", 1)
node = dom.get_first_by_tag("testsuite")
properties_node = node.get_first_by_tag("properties")
p1_node, p2_node = properties_node.find_by_tag(
"property",
)[:2]
p1_node.assert_attr(name="stats", value="all good")
p2_node.assert_attr(name="stats", value="10")
@ -1629,7 +1638,7 @@ def test_set_suite_name(
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret == 0
node = dom.find_first_by_tag("testsuite")
node = dom.get_first_by_tag("testsuite")
node.assert_attr(name=expected)
@ -1645,8 +1654,8 @@ def test_escaped_skipreason_issue3533(
"""
)
_, dom = run_and_parse()
node = dom.find_first_by_tag("testcase")
snode = node.find_first_by_tag("skipped")
node = dom.get_first_by_tag("testcase")
snode = node.get_first_by_tag("skipped")
assert "1 <> 2" in snode.text
snode.assert_attr(message="1 <> 2")
@ -1662,8 +1671,8 @@ def test_bin_escaped_skipreason(pytester: Pytester, run_and_parse: RunAndParse)
"""
)
_, dom = run_and_parse()
node = dom.find_first_by_tag("testcase")
snode = node.find_first_by_tag("skipped")
node = dom.get_first_by_tag("testcase")
snode = node.get_first_by_tag("skipped")
assert "#x1B[31;1mred#x1B[0m" in snode.text
snode.assert_attr(message="#x1B[31;1mred#x1B[0m")
@ -1684,8 +1693,8 @@ def test_escaped_setup_teardown_error(
"""
)
_, dom = run_and_parse()
node = dom.find_first_by_tag("testcase")
snode = node.find_first_by_tag("error")
node = dom.get_first_by_tag("testcase")
snode = node.get_first_by_tag("error")
assert "#x1B[31mred#x1B[m" in snode["message"]
assert "#x1B[31mred#x1B[m" in snode.text
@ -1716,7 +1725,7 @@ def test_logging_passing_tests_disabled_does_not_log_test_output(
)
result, dom = run_and_parse(family=xunit_family)
assert result.ret == 0
node = dom.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testcase")
assert len(node.find_by_tag("system-err")) == 0
assert len(node.find_by_tag("system-out")) == 0
@ -1751,7 +1760,7 @@ def test_logging_passing_tests_disabled_logs_output_for_failing_test_issue5430(
"-o", f"junit_logging={junit_logging}", family=xunit_family
)
assert result.ret == 1
node = dom.find_first_by_tag("testcase")
node = dom.get_first_by_tag("testcase")
if junit_logging == "system-out":
assert len(node.find_by_tag("system-err")) == 0
assert len(node.find_by_tag("system-out")) == 1