From 7048d5be9cd78b17baeecfdb4c278e3ddcac6a51 Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Wed, 8 Apr 2020 18:11:31 +0200 Subject: [PATCH] Fix FD leak in test__get_multicapture (#7037) Instantiating `FDCapture` creates a file descriptor already. Use "no" to not leak a fd here. --- testing/test_capture.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testing/test_capture.py b/testing/test_capture.py index 49269ee96..132ce1cc6 100644 --- a/testing/test_capture.py +++ b/testing/test_capture.py @@ -1489,7 +1489,7 @@ def test_encodedfile_writelines(tmpfile: BinaryIO) -> None: def test__get_multicapture() -> None: - assert isinstance(_get_multicapture("fd"), MultiCapture) + assert isinstance(_get_multicapture("no"), MultiCapture) pytest.raises(ValueError, _get_multicapture, "unknown").match( r"^unknown capturing method: 'unknown'" )