floraachy
/
pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adds checks for nested data structures not of the same type as the outermost structure.

This commit is contained in:
Patrick Kenny 2022-08-13 21:44:43 -04:00
parent 63d2f7f7f8
commit 70155264df
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/_pytest/python_api.py
View File

@ -376,7 +376,9 @@ class ApproxSequenceLike(ApproxBase):
def _check_type(self) -> None: def _check_type(self) -> None:
__tracebackhide__ = True __tracebackhide__ = True
for index, x in enumerate(self.expected): for index, x in enumerate(self.expected):
if isinstance(x, type(self.expected)): if (isinstance(x, Collection) or isinstance(x, Mapping)) and not isinstance(
x, STRING_TYPES
):
msg = "pytest.approx() does not support nested data structures: {!r} at index {}\n full sequence: {}" msg = "pytest.approx() does not support nested data structures: {!r} at index {}\n full sequence: {}"
raise TypeError(msg.format(x, index, pprint.pformat(self.expected))) raise TypeError(msg.format(x, index, pprint.pformat(self.expected)))

3
testing/python/approx.py
View File

@ -781,6 +781,9 @@ class TestApprox:
"x, name", "x, name",
[ [
pytest.param([[1]], "data structures", id="nested-list"), pytest.param([[1]], "data structures", id="nested-list"),
pytest.param([(1,)], "data structures", id="nested-list-tuple"),
pytest.param([{1}], "data structures", id="nested-list-set"),
pytest.param([{"key": 1}], "data structures", id="nested-list-dict"),
pytest.param({"key": {"key": 1}}, "dictionaries", id="nested-dict"), pytest.param({"key": {"key": 1}}, "dictionaries", id="nested-dict"),
], ],
) )