floraachy
/
pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
This commit is contained in:
Ben Leith 2024-02-19 09:15:35 +11:00 committed by Bruno Oliveira
parent d7339aeb42
commit 5a6563868b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
testing/logging/test_reporting.py
View File

@ -840,8 +840,7 @@ def test_log_file_mode_ini(pytester: Pytester) -> None:
# fnmatch_lines does an assertion internally # fnmatch_lines does an assertion internally
result.stdout.fnmatch_lines(["test_log_file_mode_ini.py PASSED"]) result.stdout.fnmatch_lines(["test_log_file_mode_ini.py PASSED"])
# make sure that we get a '0' exit code for the testsuite assert result.ret == ExitCode.OK
assert result.ret == 0
assert os.path.isfile(log_file) assert os.path.isfile(log_file)
with open(log_file, encoding="utf-8") as rfh: with open(log_file, encoding="utf-8") as rfh:
contents = rfh.read() contents = rfh.read()
@ -1215,7 +1214,8 @@ def test_log_set_path_with_log_file_mode(pytester: Pytester) -> None:
with open(test_second_log_file, mode="w", encoding="utf-8") as wfh: with open(test_second_log_file, mode="w", encoding="utf-8") as wfh:
wfh.write("A custom header for test 2\n") wfh.write("A custom header for test 2\n")
pytester.runpytest() result = pytester.runpytest()
assert result.ret == ExitCode.OK
with open(test_first_log_file, encoding="utf-8") as rfh: with open(test_first_log_file, encoding="utf-8") as rfh:
content = rfh.read() content = rfh.read()