Fix verbosity bug in --collect-only

This commit is contained in:
Thomas Hisch
2019-06-04 23:43:40 +02:00
committed by Bruno Oliveira
parent 6a6b6d8195
commit 577b0dffe7
3 changed files with 48 additions and 10 deletions

View File

@@ -409,10 +409,6 @@ class LoggingPlugin:
"""
self._config = config
# enable verbose output automatically if live logging is enabled
if self._log_cli_enabled() and config.getoption("verbose") < 1:
config.option.verbose = 1
self.print_logs = get_option_ini(config, "log_print")
self.formatter = self._create_formatter(
get_option_ini(config, "log_format"),
@@ -628,6 +624,15 @@ class LoggingPlugin:
@pytest.hookimpl(hookwrapper=True)
def pytest_runtestloop(self, session):
"""Runs all collected test items."""
if session.config.option.collectonly:
yield
return
if self._log_cli_enabled() and self._config.getoption("verbose") < 1:
# setting verbose flag is needed to avoid messy test progress output
self._config.option.verbose = 1
with self.live_logs_context():
if self.log_file_handler is not None:
with catching_logs(self.log_file_handler, level=self.log_file_level):