floraachy
/
pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove ignoring SkipTest during colection. 

Now it will raise an error and failure during colection instead of skipping.
This commit is contained in:
Teodor Paius 2023-04-04 14:16:46 +02:00
parent 2d2f69dab5
commit 4c3b99758b
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/_pytest/runner.py
View File

@ -375,10 +375,6 @@ def pytest_make_collect_report(collector: Collector) -> CollectReport:
outcome: Literal["passed", "skipped", "failed"] = "passed" outcome: Literal["passed", "skipped", "failed"] = "passed"
else: else:
skip_exceptions = [Skipped] skip_exceptions = [Skipped]
unittest = sys.modules.get("unittest")
if unittest is not None:
# Type ignored because unittest is loaded dynamically.
skip_exceptions.append(unittest.SkipTest) # type: ignore
if isinstance(call.excinfo.value, tuple(skip_exceptions)): if isinstance(call.excinfo.value, tuple(skip_exceptions)):
outcome = "skipped" outcome = "skipped"
r_ = collector._repr_failure_py(call.excinfo, "line") r_ = collector._repr_failure_py(call.excinfo, "line")

2
testing/test_nose.py
View File

@ -345,7 +345,7 @@ def test_SkipTest_during_collection(pytester: Pytester) -> None:
""" """
) )
result = pytester.runpytest(p) result = pytester.runpytest(p)
result.assert_outcomes(skipped=1, warnings=0) result.assert_outcomes(errors=1, skipped=0, warnings=0)
def test_SkipTest_in_test(pytester: Pytester) -> None: def test_SkipTest_in_test(pytester: Pytester) -> None:

6
testing/test_unittest.py
View File

@ -1562,6 +1562,6 @@ def test_raising_unittest_skiptest_during_collection(
passed, skipped, failed = reprec.countoutcomes() passed, skipped, failed = reprec.countoutcomes()
assert passed == 0 assert passed == 0
# Unittest reports one fake test for a skipped module. # Unittest reports one fake test for a skipped module.
assert skipped == 1 assert skipped == 0
assert failed == 0 assert failed == 1
assert reprec.ret == ExitCode.NO_TESTS_COLLECTED assert reprec.ret == ExitCode.INTERRUPTED