From 2ba8fd5bc50f293fea11a863c2b8c4dc3488762b Mon Sep 17 00:00:00 2001 From: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Date: Sun, 1 May 2022 01:05:41 -0600 Subject: [PATCH] Re-export importlib.metadata from _pytest.compat (#9906) I'm fixing a bug in mypy's --no-implicit-reexport logic in https://github.com/python/mypy/pull/12704 and mypy-primer flagged this --- changelog/9906.trivial.rst | 1 + src/_pytest/compat.py | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 changelog/9906.trivial.rst diff --git a/changelog/9906.trivial.rst b/changelog/9906.trivial.rst new file mode 100644 index 000000000..8911b7190 --- /dev/null +++ b/changelog/9906.trivial.rst @@ -0,0 +1 @@ +Made ``_pytest.compat`` re-export ``importlib_metadata`` in the eyes of type checkers. diff --git a/src/_pytest/compat.py b/src/_pytest/compat.py index e4c2a5fda..8b77de28f 100644 --- a/src/_pytest/compat.py +++ b/src/_pytest/compat.py @@ -50,9 +50,11 @@ NOTSET: "Final" = NotSetType.token # noqa: E305 # fmt: on if sys.version_info >= (3, 8): - from importlib import metadata as importlib_metadata + import importlib.metadata + + importlib_metadata = importlib.metadata else: - import importlib_metadata # noqa: F401 + import importlib_metadata as importlib_metadata # noqa: F401 def _format_args(func: Callable[..., Any]) -> str: