floraachy
/
pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve test that blocks setuptools plugins from being loaded 

Make it a parametrized test to ensure all the mocked mechanisms in
the test actually work as expected when we *do not* use "-p no:"
This commit is contained in:
Bruno Oliveira 2017-11-28 21:29:58 -02:00
parent 833f33fa0c
commit 2a75ae46c3
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
testing/test_config.py
View File

@ -460,9 +460,12 @@ def test_setuptools_importerror_issue1479(testdir, monkeypatch):
testdir.parseconfig() testdir.parseconfig()
def test_plugin_preparse_prevents_setuptools_loading(testdir, monkeypatch): @pytest.mark.parametrize('block_it', [True, False])
def test_plugin_preparse_prevents_setuptools_loading(testdir, monkeypatch, block_it):
pkg_resources = pytest.importorskip("pkg_resources") pkg_resources = pytest.importorskip("pkg_resources")
plugin_module_placeholder = object()
def my_iter(name): def my_iter(name):
assert name == "pytest11" assert name == "pytest11"
@ -478,14 +481,19 @@ def test_plugin_preparse_prevents_setuptools_loading(testdir, monkeypatch):
dist = Dist() dist = Dist()
def load(self): def load(self):
assert 0, "should not arrive here" return plugin_module_placeholder
return iter([EntryPoint()]) return iter([EntryPoint()])
monkeypatch.setattr(pkg_resources, 'iter_entry_points', my_iter) monkeypatch.setattr(pkg_resources, 'iter_entry_points', my_iter)
config = testdir.parseconfig("-p", "no:mytestplugin") args = ("-p", "no:mytestplugin") if block_it else ()
config = testdir.parseconfig(*args)
config.pluginmanager.import_plugin("mytestplugin") config.pluginmanager.import_plugin("mytestplugin")
assert "mytestplugin" not in sys.modules if block_it:
assert "mytestplugin" not in sys.modules
assert config.pluginmanager.get_plugin('mytestplugin') is None
else:
assert config.pluginmanager.get_plugin('mytestplugin') is plugin_module_placeholder
def test_cmdline_processargs_simple(testdir): def test_cmdline_processargs_simple(testdir):