From b1595d3f619169c44281ab7f0ffb245c01fbd22d Mon Sep 17 00:00:00 2001
From: Erik Bray <embray@stsci.edu>
Date: Tue, 28 May 2013 18:11:12 -0400
Subject: [PATCH 1/2] Adds a test for and fixes #112.  If attempting to write
 to the __pycache__ directory raises a permission error _write_pyc() should
 just return False to prevent any further write attempts.

---
 _pytest/assertion/rewrite.py  |  4 ++++
 testing/test_assertrewrite.py | 19 ++++++++++++++++++-
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/_pytest/assertion/rewrite.py b/_pytest/assertion/rewrite.py
index 8f51c30f3..482aa64f6 100644
--- a/_pytest/assertion/rewrite.py
+++ b/_pytest/assertion/rewrite.py
@@ -177,6 +177,10 @@ def _write_pyc(co, source_path, pyc):
             # This happens when we get a EEXIST in find_module creating the
             # __pycache__ directory and __pycache__ is by some non-dir node.
             return False
+        elif err == errno.EACCES:
+            # The directory is read-only; this can happen for example when
+            # running the tests in a package installed as root
+            return False
         raise
     try:
         fp.write(imp.get_magic())
diff --git a/testing/test_assertrewrite.py b/testing/test_assertrewrite.py
index 4841ff47c..439fcc8e5 100644
--- a/testing/test_assertrewrite.py
+++ b/testing/test_assertrewrite.py
@@ -1,4 +1,5 @@
 import os
+import stat
 import sys
 import zipfile
 import py
@@ -323,6 +324,18 @@ def test_rewritten():
     assert "@py_builtins" in globals()""")
         assert testdir.runpytest().ret == 0
 
+    def test_pycache_is_readonly(self, testdir):
+        cache = testdir.tmpdir.mkdir("__pycache__")
+        old_mode = cache.stat().mode
+        cache.chmod(old_mode ^ stat.S_IWRITE)
+        testdir.makepyfile("""
+def test_rewritten():
+    assert "@py_builtins" in globals()""")
+        try:
+            assert testdir.runpytest().ret == 0
+        finally:
+            cache.chmod(old_mode)
+
     def test_zipfile(self, testdir):
         z = testdir.tmpdir.join("myzip.zip")
         z_fn = str(z)
@@ -346,8 +359,12 @@ import test_gum.test_lizard""" % (z_fn,))
 def test_rewritten():
     assert "@py_builtins" in globals()
 """).encode("utf-8"), "wb")
+        old_mode = sub.stat().mode
         sub.chmod(320)
-        assert testdir.runpytest().ret == 0
+        try:
+            assert testdir.runpytest().ret == 0
+        finally:
+            sub.chmod(old_mode)
 
     def test_dont_write_bytecode(self, testdir, monkeypatch):
         testdir.makepyfile("""

From 17e110658460bc464592cbc4c9885524b0917cba Mon Sep 17 00:00:00 2001
From: Erik Bray <embray@stsci.edu>
Date: Fri, 7 Jun 2013 17:30:10 -0400
Subject: [PATCH 2/2] reindent a few of the blockquotes in these tests

---
 testing/test_assertrewrite.py | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/testing/test_assertrewrite.py b/testing/test_assertrewrite.py
index 439fcc8e5..34a1bc80a 100644
--- a/testing/test_assertrewrite.py
+++ b/testing/test_assertrewrite.py
@@ -320,8 +320,8 @@ class TestRewriteOnImport:
     def test_pycache_is_a_file(self, testdir):
         testdir.tmpdir.join("__pycache__").write("Hello")
         testdir.makepyfile("""
-def test_rewritten():
-    assert "@py_builtins" in globals()""")
+            def test_rewritten():
+                assert "@py_builtins" in globals()""")
         assert testdir.runpytest().ret == 0
 
     def test_pycache_is_readonly(self, testdir):
@@ -329,8 +329,8 @@ def test_rewritten():
         old_mode = cache.stat().mode
         cache.chmod(old_mode ^ stat.S_IWRITE)
         testdir.makepyfile("""
-def test_rewritten():
-    assert "@py_builtins" in globals()""")
+            def test_rewritten():
+                assert "@py_builtins" in globals()""")
         try:
             assert testdir.runpytest().ret == 0
         finally:
@@ -347,9 +347,9 @@ def test_rewritten():
             f.close()
         z.chmod(256)
         testdir.makepyfile("""
-import sys
-sys.path.append(%r)
-import test_gum.test_lizard""" % (z_fn,))
+            import sys
+            sys.path.append(%r)
+            import test_gum.test_lizard""" % (z_fn,))
         assert testdir.runpytest().ret == 0
 
     def test_readonly(self, testdir):
@@ -358,7 +358,7 @@ import test_gum.test_lizard""" % (z_fn,))
         py.builtin._totext("""
 def test_rewritten():
     assert "@py_builtins" in globals()
-""").encode("utf-8"), "wb")
+            """).encode("utf-8"), "wb")
         old_mode = sub.stat().mode
         sub.chmod(320)
         try:
@@ -368,11 +368,11 @@ def test_rewritten():
 
     def test_dont_write_bytecode(self, testdir, monkeypatch):
         testdir.makepyfile("""
-import os
-def test_no_bytecode():
-    assert "__pycache__" in __cached__
-    assert not os.path.exists(__cached__)
-    assert not os.path.exists(os.path.dirname(__cached__))""")
+            import os
+            def test_no_bytecode():
+                assert "__pycache__" in __cached__
+                assert not os.path.exists(__cached__)
+                assert not os.path.exists(os.path.dirname(__cached__))""")
         monkeypatch.setenv("PYTHONDONTWRITEBYTECODE", "1")
         assert testdir.runpytest().ret == 0