floraachy
/
pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #10638 from pytest-dev/backport-10607-to-7.2.x 

[7.2.x] Mitigate directory creation race condition
This commit is contained in:
Bruno Oliveira 2023-01-06 09:33:55 -03:00 committed by GitHub
parent 08d0dd06ac a6f85a0e3e
commit 211d08e9bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog/10607.bugfix.rst Normal file
View File

@ -0,0 +1 @@
Fix a race condition when creating junitxml reports, which could occur when multiple instances of pytest execute in parallel.

4
src/_pytest/junitxml.py
View File

@ -645,8 +645,8 @@ class LogXML:
def pytest_sessionfinish(self) -> None: def pytest_sessionfinish(self) -> None:
dirname = os.path.dirname(os.path.abspath(self.logfile)) dirname = os.path.dirname(os.path.abspath(self.logfile))
if not os.path.isdir(dirname): # exist_ok avoids filesystem race conditions between checking path existence and requesting creation
os.makedirs(dirname) os.makedirs(dirname, exist_ok=True)
with open(self.logfile, "w", encoding="utf-8") as logfile: with open(self.logfile, "w", encoding="utf-8") as logfile:
suite_stop_time = timing.time() suite_stop_time = timing.time()