floraachy
/
pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add comment about possible future refactoring in the fixture mechanism

This commit is contained in:
Bruno Oliveira 2017-09-05 19:28:39 -03:00
parent a993add783
commit 1fc185b640
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
_pytest/compat.py
View File

@ -83,6 +83,11 @@ def num_mock_patch_args(function):
def getfuncargnames(function, startindex=None, cls=None): def getfuncargnames(function, startindex=None, cls=None):
"""
@RonnyPfannschmidt: This function should be refactored when we revisit fixtures. The
fixture mechanism should ask the node for the fixture names, and not try to obtain
directly from the function object well after collection has occurred.
"""
if startindex is None and cls is not None: if startindex is None and cls is not None:
is_staticmethod = isinstance(cls.__dict__.get(function.__name__, None), staticmethod) is_staticmethod = isinstance(cls.__dict__.get(function.__name__, None), staticmethod)
startindex = 0 if is_staticmethod else 1 startindex = 0 if is_staticmethod else 1