fix issue 251 - report a skip instead of ignoring classes with init

This commit is contained in:
Ronny Pfannschmidt
2013-02-15 10:18:00 +01:00
parent aeba66ac6a
commit 0dd05023b8
3 changed files with 13 additions and 5 deletions

View File

@@ -175,9 +175,8 @@ def pytest_pycollect_makeitem(__multicall__, collector, name, obj):
#if hasattr(collector.obj, 'unittest'):
# return # we assume it's a mixin class for a TestCase derived one
if collector.classnamefilter(name):
if not hasinit(obj):
Class = collector._getcustomclass("Class")
return Class(name, parent=collector)
Class = collector._getcustomclass("Class")
return Class(name, parent=collector)
elif collector.funcnamefilter(name) and hasattr(obj, '__call__'):
if is_generator(obj):
return Generator(name, parent=collector)
@@ -394,6 +393,11 @@ class Module(pytest.File, PyCollector):
class Class(PyCollector):
""" Collector for test methods. """
def collect(self):
if hasinit(self.obj):
pytest.skip("class %s.%s with __init__ won't get collected" % (
self.obj.__module__,
self.obj.__name__,
))
return [self._getcustomclass("Instance")(name="()", parent=self)]
def setup(self):