cacheprovider: do not write README/.gitignore to existing dir

Fixes https://github.com/pytest-dev/pytest/issues/4393.
This commit is contained in:
Daniel Hahler
2018-11-14 21:55:37 +01:00
parent 9dec146edf
commit 0385c27343
3 changed files with 35 additions and 4 deletions

View File

@@ -899,5 +899,28 @@ def test_gitignore(testdir):
config = testdir.parseconfig()
cache = Cache.for_config(config)
cache.set("foo", "bar")
msg = "# created by pytest automatically, do not change\n*"
assert cache._cachedir.joinpath(".gitignore").read_text(encoding="UTF-8") == msg
msg = "# Created by pytest automatically.\n*"
gitignore_path = cache._cachedir.joinpath(".gitignore")
assert gitignore_path.read_text(encoding="UTF-8") == msg
# Does not overwrite existing/custom one.
gitignore_path.write_text("")
cache.set("something", "else")
assert gitignore_path.read_text(encoding="UTF-8") == ""
def test_does_not_create_boilerplate_in_existing_dirs(testdir):
from _pytest.cacheprovider import Cache
testdir.makeini(
"""
[pytest]
cache_dir = .
"""
)
config = testdir.parseconfig()
cache = Cache.for_config(config)
cache.set("foo", "bar")
assert not os.path.exists(".gitignore")
assert not os.path.exists("README.md")