From 0282da9ddf9d6a257c2b1d5fd4a7e48944e5c734 Mon Sep 17 00:00:00 2001 From: Eric Siegerman Date: Tue, 30 Jun 2015 19:06:28 -0400 Subject: [PATCH] Refactor slightly Check for the empty-key special case in the first loop, not the second. --- _pytest/terminal.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/_pytest/terminal.py b/_pytest/terminal.py index 82da2045d..e4181097b 100644 --- a/_pytest/terminal.py +++ b/_pytest/terminal.py @@ -530,13 +530,13 @@ def build_summary_stats_line(stats): "xfailed xpassed warnings").split() for key in stats.keys(): if key not in keys: - keys.append(key) + if key: # setup/teardown reports have an empty key, ignore them + keys.append(key) parts = [] for key in keys: - if key: # setup/teardown reports have an empty key, ignore them - val = stats.get(key, None) - if val: - parts.append("%d %s" % (len(val), key)) + val = stats.get(key, None) + if val: + parts.append("%d %s" % (len(val), key)) line = ", ".join(parts) if 'failed' in stats or 'error' in stats: