From 456428c0d7c3bb7bdda4fb94b75ae6fd4d8b9f83 Mon Sep 17 00:00:00 2001
From: tzwang <wtz1003@sina.com>
Date: Tue, 15 Oct 2024 18:10:14 +0800
Subject: [PATCH] fix instancelist bugs

---
 .../logic/inference/startallbydeploytaskidlogic.go    |  9 +++++++++
 .../logic/inference/stopallbydeploytaskidlogic.go     |  9 +++++++++
 internal/scheduler/database/aiStorage.go              | 11 -----------
 3 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/internal/logic/inference/startallbydeploytaskidlogic.go b/internal/logic/inference/startallbydeploytaskidlogic.go
index e50683b4..8bee0d5b 100644
--- a/internal/logic/inference/startallbydeploytaskidlogic.go
+++ b/internal/logic/inference/startallbydeploytaskidlogic.go
@@ -103,6 +103,15 @@ func (l *StartAllByDeployTaskIdLogic) startAll(list []*models.AiInferDeployInsta
 					return
 				}
 			}
+
+			ins.Status = "Updating"
+			err = l.svcCtx.Scheduler.AiStorages.UpdateInferDeployInstance(ins, true)
+			if err != nil {
+				wg.Done()
+				<-buf
+				return
+			}
+
 			wg.Done()
 			<-buf
 		}()
diff --git a/internal/logic/inference/stopallbydeploytaskidlogic.go b/internal/logic/inference/stopallbydeploytaskidlogic.go
index 6616c2ef..e005e331 100644
--- a/internal/logic/inference/stopallbydeploytaskidlogic.go
+++ b/internal/logic/inference/stopallbydeploytaskidlogic.go
@@ -104,6 +104,15 @@ func (l *StopAllByDeployTaskIdLogic) stopAll(list []*models.AiInferDeployInstanc
 					return
 				}
 			}
+
+			ins.Status = "Updating"
+			err = l.svcCtx.Scheduler.AiStorages.UpdateInferDeployInstance(ins, true)
+			if err != nil {
+				wg.Done()
+				<-buf
+				return
+			}
+
 			wg.Done()
 			<-buf
 		}()
diff --git a/internal/scheduler/database/aiStorage.go b/internal/scheduler/database/aiStorage.go
index 983f760b..74b5b0bc 100644
--- a/internal/scheduler/database/aiStorage.go
+++ b/internal/scheduler/database/aiStorage.go
@@ -483,17 +483,6 @@ func (s *AiStorage) UpdateDeployTaskById(id int64) error {
 	if err != nil {
 		return err
 	}
-	list, err := s.GetInstanceListByDeployTaskId(id)
-	if err != nil {
-		return err
-	}
-	for _, instance := range list {
-		instance.Status = "Updating"
-		err := s.UpdateInferDeployInstance(instance, true)
-		if err != nil {
-			return err
-		}
-	}
 	return nil
 }