From d2c1267c3dbf011da852799bb17dcc7c280f2aef Mon Sep 17 00:00:00 2001 From: Geolffrey Mena Date: Sun, 28 Aug 2022 10:31:57 -0600 Subject: [PATCH] Updated CodeReviewComments (markdown) --- CodeReviewComments.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CodeReviewComments.md b/CodeReviewComments.md index 58a11756..a8a3628f 100644 --- a/CodeReviewComments.md +++ b/CodeReviewComments.md @@ -360,6 +360,9 @@ Do not define interfaces before they are used: without a realistic example of usage, it is too difficult to see whether an interface is even necessary, let alone what methods it ought to contain. +If you need to inject a dependency into private methods consider not using interfaces as there is no ambiguity in the methods over which you have control of what is received, don't add unnecessary abstractions. The exception is the case where an abstraction is actually required to "group objects into their common behaviors". + + ``` go package consumer // consumer.go