FIX code review
This commit is contained in:
parent
3e25a7b28c
commit
1617a541fe
|
@ -8,6 +8,6 @@ class Ci::Build < Ci::RemoteBase
|
|||
scope :failed, -> { by_status('failure') }
|
||||
scope :running, -> { by_status('running') }
|
||||
scope :errored, -> { by_status('error') }
|
||||
scope :pending, -> { by_status('pending') }
|
||||
scope :pending, -> { by_status('pending') }
|
||||
scope :by_status, ->(status) { where(build_status: status) }
|
||||
end
|
||||
|
|
|
@ -13,21 +13,16 @@ class Ci::Builds::ListQuery < ApplicationQuery
|
|||
def call
|
||||
scope = @repo.builds
|
||||
|
||||
scope =
|
||||
builds =
|
||||
case params[:search]
|
||||
when 'success'
|
||||
scope.successed
|
||||
when 'pending'
|
||||
scope.pending
|
||||
when 'error'
|
||||
scope.errored
|
||||
when 'running'
|
||||
scope.running
|
||||
when 'failure'
|
||||
scope.failed
|
||||
when 'success' then scope.successed
|
||||
when 'pending' then scope.pending
|
||||
when 'error' then scope.errored
|
||||
when 'running' then scope.running
|
||||
when 'failure' then scope.failed
|
||||
else
|
||||
scope
|
||||
end
|
||||
custom_sort(scope, params[:sort_by], params[:sort_direction])
|
||||
custom_sort(builds, params[:sort_by], params[:sort_direction])
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in New Issue