floraachy
/
console
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[migration] don't skip bulk error check if count unmatch

This commit is contained in:
Kassian Sun 2023-06-08 14:09:37 +08:00 committed by Gitea
parent 9f90e49ae4
commit 355b6d3a9c
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
plugin/task_manager/index_migration/index_migration.go
View File

@ -461,15 +461,18 @@ func (p *processor) checkBulkPipelineTaskStatus(bulkTask *task.Task, cfg *migrat
) )
successDocs = migration_util.GetMapIntValue(bulkLabels, "success_docs") successDocs = migration_util.GetMapIntValue(bulkLabels, "success_docs")
if !cfg.Target.SkipCountCheck && successDocs != totalDocs { if successDocs != totalDocs {
return true, successDocs, fmt.Errorf("bulk complete but docs count unmatch: %d / %d, invalid docs: [%s] (reasons: [%s]), failure docs: [%s] (reasons: [%s])", successDocs, totalDocs, invalidDocs, invalidReasons, failureDocs, failureReasons) // check count
} if !cfg.Target.SkipCountCheck {
return true, successDocs, fmt.Errorf("bulk complete but docs count unmatch: %d / %d, invalid docs: [%s] (reasons: [%s]), failure docs: [%s] (reasons: [%s])", successDocs, totalDocs, invalidDocs, invalidReasons, failureDocs, failureReasons)
// successDocs matched but has errors }
if bulkTask.Status == task.StatusError { // has errors
return true, successDocs, nil if bulkTask.Status == task.StatusError {
return true, successDocs, fmt.Errorf("bulk pipeline failed")
}
} }
// successDocs matched, return ok
return true, successDocs, nil return true, successDocs, nil
} }