From ed8c028f7fc30cc2327410b8051c99f8eb1f58cb Mon Sep 17 00:00:00 2001 From: Alessio Zanga Date: Sat, 5 Mar 2022 00:07:01 +0100 Subject: [PATCH 1/4] Remove MSVC limitation --- CMakeLists.txt | 8 -------- 1 file changed, 8 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ab9f3af80..981130e22 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -17,15 +17,7 @@ include(GNUInstallDirs) include(CMakePackageConfigHelpers) -if(MSVC AND NOT DEFINED NOFORTRAN) - set(NOFORTRAN ON) -endif() - ####### -if(MSVC) - option(BUILD_WITHOUT_LAPACK "Do not build LAPACK and LAPACKE (Only BLAS or CBLAS)" ON) -endif() - option(BUILD_WITHOUT_CBLAS "Do not build the C interface (CBLAS) to the BLAS functions" OFF) option(DYNAMIC_ARCH "Include support for multiple CPU targets, with automatic selection at runtime (x86/x86_64, aarch64 or ppc only)" OFF) From ed2871cb71ee0ce2e86f6ed62bf2ebd10a1f3180 Mon Sep 17 00:00:00 2001 From: AlessioZanga Date: Sat, 5 Mar 2022 23:35:29 +0100 Subject: [PATCH 2/4] Change `BUILD_WITHOUT_LAPACK` to `OFF` by default --- CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 981130e22..2b99a7722 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -18,6 +18,8 @@ include(GNUInstallDirs) include(CMakePackageConfigHelpers) ####### +option(BUILD_WITHOUT_LAPACK "Do not build LAPACK and LAPACKE (Only BLAS or CBLAS)" OFF) + option(BUILD_WITHOUT_CBLAS "Do not build the C interface (CBLAS) to the BLAS functions" OFF) option(DYNAMIC_ARCH "Include support for multiple CPU targets, with automatic selection at runtime (x86/x86_64, aarch64 or ppc only)" OFF) From 2408315d105189963ea82e74340751eccfd22826 Mon Sep 17 00:00:00 2001 From: Martin Kroeker Date: Tue, 22 Mar 2022 21:37:55 +0100 Subject: [PATCH 3/4] Skip tests if Windows powershell added a BOM --- test/CMakeLists.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index e4ee8b28b..5214d9cab 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -30,6 +30,10 @@ if(WIN32) FILE(WRITE ${CMAKE_CURRENT_BINARY_DIR}/test_helper.ps1 "if (Test-Path $args[2]) { Remove-Item -Force $args[2] } \n" "$ErrorActionPreference = \"Stop\"\n" +"If ((Get-Content $args[1] | & file - | %{$_ -match \"BOM\"}) -contains $true) {\n" +"echo 'Skipped due to wrong input encoding'\n" +"exit 0\n" +"}\n" "Get-Content $args[1] | & $args[0]\n" "If ((Get-Content $args[2] | %{$_ -match \"FATAL\"}) -contains $true) {\n" "echo Error\n" From a0e86adf934561ddd5e4e7aa9e41f247aff2f395 Mon Sep 17 00:00:00 2001 From: Martin Kroeker Date: Tue, 22 Mar 2022 21:51:09 +0100 Subject: [PATCH 4/4] Update Windows jobs in Azure CI to use Windows2022 --- azure-pipelines.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 04ed428de..10d639a4a 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -65,7 +65,7 @@ jobs: - task: CMake@1 inputs: workingDirectory: 'build' # Optional - cmakeArgs: '-G "Visual Studio 16 2019" ..' + cmakeArgs: '-G "Visual Studio 17 2022" ..' - task: CMake@1 inputs: cmakeArgs: '--build . --config Release' @@ -103,7 +103,7 @@ jobs: - job: Windows_flang_clang pool: - vmImage: 'windows-latest' + vmImage: 'windows-2022' steps: - script: | set "PATH=C:\Miniconda\Scripts;C:\Miniconda\Library\bin;C:\Miniconda\Library\usr\bin;C:\Miniconda\condabin;%PATH%" @@ -114,7 +114,7 @@ jobs: conda install --yes --quiet ninja flang mkdir build cd build - call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvars64.bat" + call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat" cmake -G "Ninja" -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -DCMAKE_Fortran_COMPILER=flang -DCMAKE_MT=mt -DCMAKE_BUILD_TYPE=Release -DMSVC_STATIC_CRT=ON .. cmake --build . --config Release ctest @@ -178,7 +178,7 @@ jobs: cmake -DTARGET=CORE2 -DDYNAMIC_ARCH=1 -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_Fortran_COMPILER=gfortran-10 -DBUILD_SHARED_LIBS=ON .. cmake --build . ctest - + - job: OSX_Ifort_Clang pool: vmImage: 'macOS-10.15'