From 77b197bc93c745a1bfb82f2d425e8ef7dec7f221 Mon Sep 17 00:00:00 2001 From: Christoph Conrads Date: Thu, 10 Aug 2017 12:47:18 -0400 Subject: [PATCH 1/2] Make: fix installation instructions The installation instructions as shown after successfully compiling OpenBLAS are wrong because this arguments used during compilation have to be provided to Make again. --- Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1b9bcb118..ce3f4b875 100644 --- a/Makefile +++ b/Makefile @@ -81,8 +81,9 @@ ifeq ($(OSNAME), Darwin) @echo "install_name_tool -id /new/absolute/path/to/$(LIBDYNNAME) $(LIBDYNNAME)" endif @echo - @echo "To install the library, you can run \"make PREFIX=/path/to/your/installation install\"." - @echo + @echo "To install the library, you can run" + @echo " make PREFIX=/path/to/your/installation install" + @echo "where '' is the set of argument used for compilation." shared : ifndef NO_SHARED From be8e8228ae33069727936679ffab6284e79c3f59 Mon Sep 17 00:00:00 2001 From: Christoph Conrads Date: Thu, 10 Aug 2017 14:22:26 -0400 Subject: [PATCH 2/2] Make: show installation instructions after build --- Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index ce3f4b875..c3181e2fd 100644 --- a/Makefile +++ b/Makefile @@ -28,6 +28,9 @@ SUBDIRS_ALL = $(SUBDIRS) test ctest utest exports benchmark ../laswp ../bench .PHONY : all libs netlib $(RELA) test ctest shared install .NOTPARALLEL : all libs $(RELA) prof lapack-test install blas-test +# source: https://stackoverflow.com/questions/52674/simplest-way-to-reverse-the-order-of-strings-in-a-make-variable/14260762#14260762 +reverse = $(if $(wordlist 2,2,$(1)),$(call reverse,$(wordlist 2,$(words $(1)),$(1))) $(firstword $(1)),$(1)) + all :: libs netlib $(RELA) tests shared @echo @echo " OpenBLAS build complete. ($(LIB_COMPONENTS))" @@ -82,8 +85,7 @@ ifeq ($(OSNAME), Darwin) endif @echo @echo "To install the library, you can run" - @echo " make PREFIX=/path/to/your/installation install" - @echo "where '' is the set of argument used for compilation." + @echo " make $(call reverse,$(MAKEFLAGS)) PREFIX=/path/to/your/installation install" shared : ifndef NO_SHARED