floraachy
/
OpenBLAS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #4841 from martin-frbg/lapack1033 

Prevent compilers from using FMA that could increase error in ?GEEVX (Reference-LAPACK PR 1033)
This commit is contained in:
Martin Kroeker 2024-08-05 23:50:40 +02:00 committed by GitHub
parent ae9e0e36c3 c8b4ceca85
commit 5bdd3a05f0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lapack-netlib/SRC/dlanv2.f
View File

@ -109,7 +109,7 @@
*> \author Univ. of Colorado Denver
*> \author NAG Ltd.
*
*> \ingroup doubleOTHERauxiliary
*> \ingroup lanv2
*
*> \par Further Details:
* =====================
@ -144,7 +144,7 @@
* ..
* .. Local Scalars ..
DOUBLE PRECISION AA, BB, BCMAX, BCMIS, CC, CS1, DD, EPS, P, SAB,
$ SAC, SCALE, SIGMA, SN1, TAU, TEMP, Z, SAFMIN,
$ SAC, SCALE, SIGMA, SN1, TAU, TEMP, Z, SAFMIN,
$ SAFMN2, SAFMX2
INTEGER COUNT
* ..
@ -248,10 +248,14 @@
*
* Compute [ A B ] = [ CS SN ] [ AA BB ]
* [ C D ] [-SN CS ] [ CC DD ]
*
* Note: Some of the multiplications are wrapped in parentheses to
* prevent compilers from using FMA instructions. See
* https://github.com/Reference-LAPACK/lapack/issues/1031.
*
A = AA*CS + CC*SN
B = BB*CS + DD*SN
C = -AA*SN + CC*CS
B = ( BB*CS ) + ( DD*SN )
C = -( AA*SN ) + ( CC*CS )
D = -BB*SN + DD*CS
*
TEMP = HALF*( A+D )

12
lapack-netlib/SRC/slanv2.f
View File

@ -109,7 +109,7 @@
*> \author Univ. of Colorado Denver
*> \author NAG Ltd.
*
*> \ingroup realOTHERauxiliary
*> \ingroup lanv2
*
*> \par Further Details:
* =====================
@ -144,7 +144,7 @@
* ..
* .. Local Scalars ..
REAL AA, BB, BCMAX, BCMIS, CC, CS1, DD, EPS, P, SAB,
$ SAC, SCALE, SIGMA, SN1, TAU, TEMP, Z, SAFMIN,
$ SAC, SCALE, SIGMA, SN1, TAU, TEMP, Z, SAFMIN,
$ SAFMN2, SAFMX2
INTEGER COUNT
* ..
@ -248,10 +248,14 @@
*
* Compute [ A B ] = [ CS SN ] [ AA BB ]
* [ C D ] [-SN CS ] [ CC DD ]
*
* Note: Some of the multiplications are wrapped in parentheses to
* prevent compilers from using FMA instructions. See
* https://github.com/Reference-LAPACK/lapack/issues/1031.
*
A = AA*CS + CC*SN
B = BB*CS + DD*SN
C = -AA*SN + CC*CS
B = ( BB*CS ) + ( DD*SN )
C = -( AA*SN ) + ( CC*CS )
D = -BB*SN + DD*CS
*
TEMP = HALF*( A+D )