close_issue_2
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,903 Commits 12 Branches 4 Tags 14 MiB
Go 96.4%
JavaScript 1.3%
TypeScript 0.9%
HTML 0.7%
CSS 0.6%
Go to file
Brad Fitzpatrick edf8e6fef8 cmd/goimports, imports: optimize directory scanning and other things 
This brings goimports from 160ms to 100ms on my laptop, and under 50ms
on my Linux machine.

Using cmd/trace, I noticed that filepath.Walk is inherently slow.
See https://golang.org/issue/16399 for details.

Instead, this CL introduces a new (private) filepath.Walk
implementation, optimized for speed and avoiding unnecessary work.

In addition to avoid an Lstat per file, it also reads directories
concurrently. The old goimports code did that too, but now that logic
is removed from goimports and the code is simplified.

This also adds some profiling command line flags to goimports that I
found useful.

Updates golang/go#16367 (goimports is slow)
Updates golang/go#16399 (filepath.Walk is slow)

Change-Id: I708d570cbaad3fa9ad75a12054f5a932ee159b84
Reviewed-on: https://go-review.googlesource.com/25001
Reviewed-by: Andrew Gerrand <adg@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
 		2016-07-19 03:21:45 +00:00
benchmark/parse benchmark/parse: fix cosmetic defect in error str. 2015-02-02 17:07:43 +00:00
blog tools: add import comments. 2014-12-09 22:42:16 +00:00
cmd cmd/goimports, imports: optimize directory scanning and other things 2016-07-19 03:21:45 +00:00
container/intsets container/intsets: use fast popcount with gccgo 2015-11-11 02:17:02 +00:00
cover cover: fixed broken error message 2016-03-08 18:20:19 +00:00
go go/gcimporter15: backport of https://golang.org/cl/23606/ 2016-07-15 21:35:32 +00:00
godoc godoc/static: use window scope for checking notesEnabled 2016-07-17 07:19:41 +00:00
imports cmd/goimports, imports: optimize directory scanning and other things 2016-07-19 03:21:45 +00:00
oracle cmd/oracle: announce planned deletion in 2.5 months 2016-07-18 23:21:13 +00:00
playground playground: fix share URL 2016-05-02 16:10:21 +00:00
present x/tools/present: add presenter notes documentation 2016-06-01 21:14:44 +00:00
refactor refactor/rename: fix two bugs related to MS Windows' path separator 2016-07-15 14:58:04 +00:00
.gitattributes tools: copying .gitattributes to all subrepositories (fixes windows build) 2014-12-23 06:32:51 +00:00
.gitignore dashboard: rearrange tree, in prep for packagification 2015-01-15 02:58:11 +00:00
AUTHORS go.empty: prototype for new subrepository 2012-01-25 14:45:13 -05:00
CONTRIBUTING.md doc: add CONTRIBUTING.md 2015-02-18 23:43:38 +00:00
CONTRIBUTORS go.empty: prototype for new subrepository 2012-01-25 14:45:13 -05:00
LICENSE LICENSE: add 2012-03-17 15:20:58 +11:00
PATENTS go.empty: add PATENTS file to the subrepo. 2012-04-16 11:24:04 +10:00
README go.tools/README: minor correction. 2013-10-29 13:20:58 -04:00
codereview.cfg tools: add codereview.cfg 2015-03-18 17:04:00 +00:00

README 

This subrepository holds the source for various packages and tools that support
the Go programming language.

Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go oracle and the test coverage tool, can be fetched with "go get".

Packages include a type-checker for Go and an implementation of the
Static Single Assignment form (SSA) representation for Go programs.

To submit changes to this repository, see http://golang.org/doc/contribute.html.