We err on the side of refreshing package metadata if something goes wrong getting a file's AST, but we don't want to refresh in the case of context cancellation. Now we check for that error explicitly. In particular, I noticed that completions would stop working when typing quickly. Refreshing the metadata triggers "go list" calls which can take a long time in certain cases. Change-Id: I1b0c580e5541b1536a69ccaef241d7e8c5720d60 GitHub-Last-Rev: 6a82bfb586f93ef5e8e5996b11e06ffc7808f529 GitHub-Pull-Request: golang/tools#130 Reviewed-on: https://go-review.googlesource.com/c/tools/+/184977 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> |
||
|---|---|---|
| .. | ||
| apidiff | ||
| fastwalk | ||
| gopathwalk | ||
| imports | ||
| jsonrpc2 | ||
| lsp | ||
| memoize | ||
| module | ||
| semver | ||
| span | ||
| tool | ||
| txtar | ||