tools/imports
Heschi Kreinick d4971274fe imports: don't remove imports that conflict with globals
When a package contains both a var and an import that produce the same
identifier, the compiler will complain. I had thought that it made sense
to remove the redundant imports in that case. However, we can't reliably
tell whether a global from one file is in scope in another file. Most
notably, having multiple main packages in the same directory is pretty
common, and if someone declares a var in one that matches an import in
another, we don't want to remove the import.

Change-Id: I49f58fccdb8a8542ec85cf4d80d3e20d3159d2c7
Reviewed-on: https://go-review.googlesource.com/c/154740
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
2018-12-18 20:40:10 +00:00
..
fix.go imports: don't remove imports that conflict with globals 2018-12-18 20:40:10 +00:00
fix_test.go imports: don't remove imports that conflict with globals 2018-12-18 20:40:10 +00:00
imports.go imports: redesign fixImports 2018-12-03 18:26:12 +00:00
mkindex.go go.tools/imports: move goimports from github to go.tools. 2013-12-17 21:21:03 -05:00
mkstdlib.go imports: redesign fixImports 2018-12-03 18:26:12 +00:00
sortimports.go Revert "imports: support repairing import grouping/ordering" 2018-10-24 17:12:08 +00:00
zstdlib.go imports: redesign fixImports 2018-12-03 18:26:12 +00:00