close_issue_2
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
tools/internal/lsp/cache
History
Muir Manders d255de4fdb internal/lsp: don't refresh metadata when context canceled 
We err on the side of refreshing package metadata if something goes
wrong getting a file's AST, but we don't want to refresh in the case
of context cancellation. Now we check for that error explicitly.

In particular, I noticed that completions would stop working when
typing quickly. Refreshing the metadata triggers "go list" calls which
can take a long time in certain cases.

Change-Id: I1b0c580e5541b1536a69ccaef241d7e8c5720d60
GitHub-Last-Rev: 6a82bfb586f93ef5e8e5996b11e06ffc7808f529
GitHub-Pull-Request: golang/tools#130
Reviewed-on: https://go-review.googlesource.com/c/tools/+/184977
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
 		2019-07-09 18:24:20 +00:00
..
cache.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
check.go internal/lsp: connect memoize actions to their callers 2019-07-03 19:15:39 +00:00
external.go internal/lsp: add some trace spans to important functions 2019-07-03 19:14:57 +00:00
file.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
gofile.go internal/lsp: fix bug where gopls hangs on manually typed imports 2019-07-01 17:55:09 +00:00
load.go internal/lsp: don't refresh metadata when context canceled 2019-07-09 18:24:20 +00:00
modfile.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
parse.go internal/lsp: add some trace spans to important functions 2019-07-03 19:14:57 +00:00
pkg.go internal/lsp: plumb suggested fixes through the LSP 2019-06-26 21:02:18 +00:00
session.go internal/lsp: check file content on disk when opening 2019-07-01 19:36:37 +00:00
sumfile.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
token.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
view.go internal/lsp: fix deadlocks loading lots of files at once 2019-07-03 17:22:52 +00:00
watcher.go internal/lsp: fix deadlocks loading lots of files at once 2019-07-03 17:22:52 +00:00