Now that we support checking for duplicate struct field tags across anonymous struct fields, we must deal with the fact that the files involved in such a warning may not be in the same package or directory. This could lead to errors where a file was mentioned in a package where it didn't exist. Or even worse, point at a location within an existing file that doesn't contain the field we want, causing even further confusion to the user. To fix this, always make the "also at" positions relative to the current warning, if possible. Fixes #29130. Change-Id: Iaa29b406978f1671bdfb2ddddb7058eeffec92a9 Reviewed-on: https://go-review.googlesource.com/c/155899 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com> |
||
|---|---|---|
| .. | ||
| analysistest | ||
| cmd/vet | ||
| internal | ||
| multichecker | ||
| passes | ||
| singlechecker | ||
| unitchecker | ||
| analysis.go | ||
| doc.go | ||
| validate.go | ||