close_issue_2
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
tools/internal/lsp/source
History
Rebecca Stambler 3cbd95df51 internal/lsp: support a file belonging to multiple packages 
This change adds supports for a package belonging to multiple files.
It requires additional packages.Loads for all of the packages to which a
file belongs (for example, if a non-test file also belongs to a package's
test variant).

For now, we re-run go/packages.Load for each file we open, regardless of
whether or not we already know about it.

This solves the issue of packages randomly belonging to a test or not.
Follow-up work needs to be done to support multiple packages in
references, rename, and diagnostics.

Fixes golang/go#32791
Fixes golang/go#30100

Change-Id: I0a5870a05825fc16cc46d405ef50c775094b0fbb
Reviewed-on: https://go-review.googlesource.com/c/tools/+/183628
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
 		2019-06-26 17:56:19 +00:00
..
analysis.go internal/lsp: update analysis runner for new features 2019-06-14 15:20:01 +00:00
completion.go internal/lsp: support a file belonging to multiple packages 2019-06-26 17:56:19 +00:00
completion_format.go internal/lsp: fix function value completions 2019-06-20 15:43:39 +00:00
completion_snippet.go internal/lsp: build the packages config on demand from proper configuration 2019-05-21 17:12:43 +00:00
diagnostics.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
diagnostics_test.go internal/span: change URI.Filename so it just returns the filename 2019-06-10 21:39:43 +00:00
enums.go internal/lsp: switch completion item tests to using the enum strings 2019-04-17 17:57:43 +00:00
format.go internal/lsp: remove source.FileContent 2019-06-06 05:02:23 +00:00
highlight.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
hover.go internal/lsp: attach documentation to signature help 2019-06-06 17:46:28 +00:00
identifier.go internal/lsp: support a file belonging to multiple packages 2019-06-26 17:56:19 +00:00
references.go internal/lsp: support a file belonging to multiple packages 2019-06-26 17:56:19 +00:00
rename.go internal/lsp: support a file belonging to multiple packages 2019-06-26 17:56:19 +00:00
rename_check.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
signature_help.go internal/lsp: fix some issues with trimming ASTs 2019-06-07 20:08:10 +00:00
source_test.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
symbols.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
util.go internal/lsp: fix function value completions 2019-06-20 15:43:39 +00:00
view.go internal/lsp: support a file belonging to multiple packages 2019-06-26 17:56:19 +00:00