e54115a062
The "analyses" cache in lsp/cache.(*Package).GetActionGraph was not getting cleared on errors. This could result in future calls to GetActionGraph waiting on the "ready" channel indefinitely. This in turn caused the goroutine in cacheAndDiagnose to block indefinitely and never send the diagnostic results back. Now we use a defer statement to always close the channel. If we did not succeed, we also clear out the cache entry and set a "succeeded = false" flag to signal waiters that they need to retry. If in the future errors other than context.Canceled/Timeout are possible, this retry behavior may need to be revisited. Fixes golang/go#30786 Change-Id: Icacc9188f1500b00f2178521ce373a2c1363f932 GitHub-Last-Rev: 7c43afd4286a69b0d35a625716e6934c72c4cef5 GitHub-Pull-Request: golang/tools#91 Reviewed-on: https://go-review.googlesource.com/c/tools/+/173977 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> |
||
|---|---|---|
| .. | ||
| apidiff | ||
| fastwalk | ||
| gopathwalk | ||
| jsonrpc2 | ||
| lsp | ||
| module | ||
| semver | ||
| span | ||
| tool | ||
| txtar | ||