tools/internal/lsp
Muir Manders 22e91af008 internal/lsp: apply type modifiers to completion candidate
In situations like:

var buf bytes.Buffer
var w io.Writer = &b<>

if we want to complete to "buf" properly we need to apply the "&" type
modifier to buf's type of bytes.Buffer to see that it is assignable
to type io.Writer. Previously we applied type modifiers in reverse to
the "expected" type (io.Writer in this case), but that is obviously
incorrect in this situation since it is nonsensical to
dereference (the reverse of "&") io.Writer.

Change-Id: Ib7ab5761f625217e023286384c23b8c60e677aac
GitHub-Last-Rev: 4be528f2572c9c987334552e3f8a31d4eddce81a
GitHub-Pull-Request: golang/tools#121
Reviewed-on: https://go-review.googlesource.com/c/tools/+/182598
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-06-19 20:27:14 +00:00
..
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache internal/lsp: add a field on the package to store diagnostics 2019-06-19 16:20:43 +00:00
cmd internal/lsp: remove the redundant `Server.Run()` call. 2019-06-19 15:21:02 +00:00
debug internal/lsp: switching debug pages to not use the default mux 2019-06-18 23:29:48 +00:00
diff internal/lsp/diff: remove redundant memory allocate and copy operations in function 'shortestEditSequence'. 2019-06-17 16:22:25 +00:00
protocol internal/lsp: block rather than reject when the message queue is full 2019-06-14 18:56:17 +00:00
snippet internal/lsp: introduce snippet builder object 2019-04-25 18:37:29 +00:00
source internal/lsp: apply type modifiers to completion candidate 2019-06-19 20:27:14 +00:00
testdata internal/lsp: apply type modifiers to completion candidate 2019-06-19 20:27:14 +00:00
tests internal/lsp: apply type modifiers to completion candidate 2019-06-19 20:27:14 +00:00
xlog internal/lsp: add the ability to log back to the client 2019-04-01 16:22:08 +00:00
code_action.go internal/lsp: add structured layers to the cache 2019-05-16 21:30:38 +00:00
completion.go internal/lsp: fix completion insertion 2019-05-17 18:32:58 +00:00
definition.go internal/lsp: attach documentation to signature help 2019-06-06 17:46:28 +00:00
diagnostics.go internal/lsp: parse filenames only out of go list errors 2019-06-14 19:27:58 +00:00
format.go internal/lsp: add structured layers to the cache 2019-05-16 21:30:38 +00:00
general.go internal/lsp: enable textDocument/didSave notifications 2019-06-18 23:32:49 +00:00
highlight.go internal/lsp: add structured layers to the cache 2019-05-16 21:30:38 +00:00
hover.go internal/lsp: attach documentation to signature help 2019-06-06 17:46:28 +00:00
link.go internal/lsp: build the packages config on demand from proper configuration 2019-05-21 17:12:43 +00:00
lsp_test.go internal/span: change URI.Filename so it just returns the filename 2019-06-10 21:39:43 +00:00
references.go internal/lsp: add find all references 2019-06-10 19:06:22 +00:00
reset_golden.sh internal/lsp: fix definition tests to use golden files 2019-05-10 21:06:55 +00:00
server.go internal/lsp: remove the redundant `Server.Run()` call. 2019-06-19 15:21:02 +00:00
signature_help.go internal/lsp: reply with nil, rather than empty, signature help 2019-06-08 02:21:20 +00:00
symbols.go internal/lsp: add structured layers to the cache 2019-05-16 21:30:38 +00:00
text_synchronization.go internal/lsp: clear diagnostics when all files from a package are closed 2019-06-14 20:56:25 +00:00
util.go internal/span: change URI.Filename so it just returns the filename 2019-06-10 21:39:43 +00:00
workspace.go internal/lsp: build the packages config on demand from proper configuration 2019-05-21 17:12:43 +00:00