1) Killing proceses on timeout was wrong: the os/exec package will never return our package's error type from its Wait. 2) fix a goroutine leak on timeout. 3) unexported an undocumented and elsewhere-unused type. 4) rename timeout type to end in "Error", per convention, not Err. LGTM=adg R=adg CC=golang-codereviews https://golang.org/cl/74290043 |
||
|---|---|---|
| .. | ||
| Makefile | ||
| doc.go | ||
| env.go | ||
| exec.go | ||
| http.go | ||
| main.go | ||
| vcs.go | ||