From fe74a4186116b8d7dd38a723993e0d84f8834b34 Mon Sep 17 00:00:00 2001 From: Andrew Gerrand Date: Fri, 5 Feb 2016 11:04:38 +1100 Subject: [PATCH] godoc: don't quote search term to avoid escaping regexps This is safe because the page title is HTML-escaped as it is displayed. Fixes golang/go#14208 Change-Id: Ib98071a08adeaad79043b9a2eb07bc7a5e8d251d Reviewed-on: https://go-review.googlesource.com/19242 Reviewed-by: Brad Fitzpatrick --- godoc/search.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/godoc/search.go b/godoc/search.go index ff3f2beb..63d9e76d 100644 --- a/godoc/search.go +++ b/godoc/search.go @@ -110,7 +110,7 @@ func (p *Presentation) HandleSearch(w http.ResponseWriter, r *http.Request) { var title string if haveResults := contents.Len() > 0; haveResults { - title = fmt.Sprintf(`Results for query %q`, query) + title = fmt.Sprintf(`Results for query: %v`, query) if !p.Corpus.IndexEnabled { result.Alert = "" }