From ed0dc450797fdfbe6a9ee6bf3381a02099b897f9 Mon Sep 17 00:00:00 2001 From: Tai Date: Mon, 10 Jun 2019 16:34:22 +0800 Subject: [PATCH] go/analysis/passes/composite: whitelist unicode.Range32 We already whitelist unicode.Range16. This CL whitelists unicode.Range32 also, to be more consistent. Fixes golang/go#32507 Change-Id: I72a8cf7c63845510e51c7e6ebbd3b627ecb7e0da Reviewed-on: https://go-review.googlesource.com/c/tools/+/180922 Reviewed-by: Emmanuel Odeke Run-TryBot: Emmanuel Odeke --- go/analysis/passes/composite/testdata/src/a/a.go | 6 ++++++ go/analysis/passes/composite/whitelist.go | 1 + 2 files changed, 7 insertions(+) diff --git a/go/analysis/passes/composite/testdata/src/a/a.go b/go/analysis/passes/composite/testdata/src/a/a.go index 172ac54e..3a5bc203 100644 --- a/go/analysis/passes/composite/testdata/src/a/a.go +++ b/go/analysis/passes/composite/testdata/src/a/a.go @@ -119,3 +119,9 @@ var badNamedPointerSliceLiteral = []*unicode.CaseRange{ {1, 2, delta}, // want "unkeyed fields" &unicode.CaseRange{1, 2, delta}, // want "unkeyed fields" } + +// unicode.Range16 is whitelisted, so there'll be no vet error +var range16 = unicode.Range16{0xfdd0, 0xfdef, 1} + +// unicode.Range32 is whitelisted, so there'll be no vet error +var range32 = unicode.Range32{0x1fffe, 0x1ffff, 1} diff --git a/go/analysis/passes/composite/whitelist.go b/go/analysis/passes/composite/whitelist.go index ab609f27..1e5f5fd2 100644 --- a/go/analysis/passes/composite/whitelist.go +++ b/go/analysis/passes/composite/whitelist.go @@ -24,6 +24,7 @@ var unkeyedLiteral = map[string]bool{ "image.Uniform": true, "unicode.Range16": true, + "unicode.Range32": true, // These three structs are used in generated test main files, // but the generator can be trusted.