From e14d0b6f6b4dcde66d9c4ff8951a0d37001d6f30 Mon Sep 17 00:00:00 2001 From: Hyang-Ah Hana Kim Date: Thu, 15 Jan 2015 13:16:57 -0500 Subject: [PATCH] cmd/godoc: godoc test needs clean up tmp dir when buildGodoc fails. Change-Id: I584ed27d37a85d39294b07febf396f567d4016a5 Reviewed-on: https://go-review.googlesource.com/2901 Reviewed-by: Brad Fitzpatrick --- cmd/godoc/godoc_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cmd/godoc/godoc_test.go b/cmd/godoc/godoc_test.go index 946c1ec0..feaad2f5 100644 --- a/cmd/godoc/godoc_test.go +++ b/cmd/godoc/godoc_test.go @@ -74,6 +74,11 @@ func buildGodoc(t *testing.T) (bin string, cleanup func()) { if err != nil { t.Fatal(err) } + defer func() { + if cleanup == nil { // probably, go build failed. + os.RemoveAll(tmp) + } + }() bin = filepath.Join(tmp, "godoc") if runtime.GOOS == "windows" {