From e0e20f22c01fe0f7629a795e1ab071563f5e29e6 Mon Sep 17 00:00:00 2001 From: Michael Matloob Date: Thu, 20 Jun 2019 11:19:49 -0400 Subject: [PATCH] go/packages: trim errors returned by go list go list sometimes sticks a leading newline in its error messages have go/packages trim them until go list does the right thing (of course, no one should depend on this behavior) Fixes golang/go#32363 Change-Id: I6e145fb85bfc9d710c5f06146a64ec6919f59e36 Reviewed-on: https://go-review.googlesource.com/c/tools/+/183258 Run-TryBot: Michael Matloob TryBot-Result: Gobot Gobot Reviewed-by: Dominik Honnef --- go/packages/golist.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/packages/golist.go b/go/packages/golist.go index 5b730c34..172effdd 100644 --- a/go/packages/golist.go +++ b/go/packages/golist.go @@ -699,7 +699,7 @@ func golistDriver(cfg *Config, words ...string) (*driverResponse, error) { if p.Error != nil { pkg.Errors = append(pkg.Errors, Error{ Pos: p.Error.Pos, - Msg: p.Error.Err, + Msg: strings.TrimSpace(p.Error.Err), // Trim to work around golang.org/issue/32363. }) }