From e0ba1bf74c385300c872a79b73a89ada47f3e4e4 Mon Sep 17 00:00:00 2001 From: David Crawshaw Date: Tue, 13 Jan 2015 11:00:57 -0500 Subject: [PATCH] cmd/vet: keep processing files after warning This lets go vet produce useful results for syscall on darwin/amd64, otherwise it gets caught on asm.s. Change-Id: I3daa49cf61eeada52eb9d4e94e40c4d21d1d5b2d Reviewed-on: https://go-review.googlesource.com/2741 Reviewed-by: Rob Pike --- cmd/vet/asmdecl.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/vet/asmdecl.go b/cmd/vet/asmdecl.go index 954ffbd9..e1ea9a21 100644 --- a/cmd/vet/asmdecl.go +++ b/cmd/vet/asmdecl.go @@ -110,6 +110,7 @@ func asmCheck(pkg *Package) { } } +Files: for _, f := range pkg.files { if !strings.HasSuffix(f.name, ".s") { continue @@ -173,7 +174,7 @@ func asmCheck(pkg *Package) { flushRet() if arch == "" { f.Warnf(token.NoPos, "%s: cannot determine architecture for assembly file", f.name) - return + continue Files } fnName = m[1] fn = knownFunc[m[1]][arch]