close_issue_2
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go/ssa/interp: skip failing test 

This test introduces noise when using 'go test all' or 'go test ./...'
to test go/packages and the tools that depend on it.

Since it has been broken for around a month, skip it indefinitely.

Updates golang/go#27292

Change-Id: I796292310332712e14bc8a0b73e36a8ed6f8a73f
Reviewed-on: https://go-review.googlesource.com/137315
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Bryan C. Mills 2018-09-25 10:54:35 -04:00
parent ff3f684ce0
commit dca76387a0
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
go/ssa/interp/interp_test.go
View File

@ -156,9 +156,7 @@ var testdataTests = []string{
type successPredicate func(exitcode int, output string) error type successPredicate func(exitcode int, output string) error
func run(t *testing.T, dir, input string, success successPredicate) bool { func run(t *testing.T, dir, input string, success successPredicate) bool {
if testing.Short() { t.Skip("golang.org/issue/27292")
t.Skip("test breaks regularly; skipping in short mode so a failure doesn't affect trybots or build.golang.org; golang.org/issue/27292")
}
if runtime.GOOS == "darwin" { if runtime.GOOS == "darwin" {
t.Skip("skipping on darwin until golang.org/issue/23166 is fixed") t.Skip("skipping on darwin until golang.org/issue/23166 is fixed")
} }