close_issue_2
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/go/ssa: use types.WriteSignature 

LGTM=gri
R=gri
CC=golang-codereviews
https://golang.org/cl/57930043
This commit is contained in:
Alan Donovan 2014-01-28 17:04:41 -05:00
parent 64ec206bfd
commit d0efad3082
1 changed files with 4 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
go/ssa/func.go
View File

@ -7,6 +7,7 @@ package ssa
// This file implements the Function and BasicBlock types.
import (
"bytes"
"fmt"
"go/ast"
"go/token"
@ -498,8 +499,6 @@ func (f *Function) RelString(from *types.Package) string {
}
// writeSignature writes to w the signature sig in declaration syntax.
// Derived from types.Signature.String().
//
func writeSignature(w io.Writer, pkg *types.Package, name string, sig *types.Signature, params []*Parameter) {
io.WriteString(w, "func ")
if recv := sig.Recv(); recv != nil {
@ -510,33 +509,11 @@ func writeSignature(w io.Writer, pkg *types.Package, name string, sig *types.Sig
}
io.WriteString(w, relType(params[0].Type(), pkg))
io.WriteString(w, ") ")
params = params[1:]
}
io.WriteString(w, name)
io.WriteString(w, "(")
for i, v := range params {
if i > 0 {
io.WriteString(w, ", ")
}
io.WriteString(w, v.Name())
io.WriteString(w, " ")
if sig.Variadic() && i == len(params)-1 {
io.WriteString(w, "...")
io.WriteString(w, relType(v.Type().Underlying().(*types.Slice).Elem(), pkg))
} else {
io.WriteString(w, relType(v.Type(), pkg))
}
}
io.WriteString(w, ")")
if n := sig.Results().Len(); n > 0 {
io.WriteString(w, " ")
r := sig.Results()
if n == 1 && r.At(0).Name() == "" {
io.WriteString(w, relType(r.At(0).Type(), pkg))
} else {
io.WriteString(w, relType(r, pkg))
}
}
var sigbuf bytes.Buffer
types.WriteSignature(&sigbuf, pkg, sig)
w.Write(sigbuf.Bytes())
}
func (f *Function) pkgobj() *types.Package {