close_issue_2
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/cmd/stringer: delete needless subtraction of zero in generated code 

LGTM=gri
R=gri
CC=golang-codereviews
https://golang.org/cl/136270043
This commit is contained in:
Rob Pike 2014-09-05 17:05:28 -07:00
parent d0448f16e3
commit d03e8a67df
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cmd/stringer/golden_test.go
View File

@ -203,7 +203,6 @@ var (
func (i Unum) String() string { func (i Unum) String() string {
switch { switch {
case 0 <= i && i <= 2: case 0 <= i && i <= 2:
i -= 0
lo := uint8(0) lo := uint8(0)
if i > 0 { if i > 0 {
lo = _Unum_index_0[i-1] lo = _Unum_index_0[i-1]

2
cmd/stringer/stringer.go
View File

@ -611,7 +611,9 @@ func (g *Generator) buildMultipleRuns(runs [][]Value, typeName string) {
continue continue
} }
g.Printf("\tcase %s <= i && i <= %s:\n", &values[0], &values[len(values)-1]) g.Printf("\tcase %s <= i && i <= %s:\n", &values[0], &values[len(values)-1])
if values[0].value != 0 {
g.Printf("\t\ti -= %s\n", &values[0]) g.Printf("\t\ti -= %s\n", &values[0])
}
g.Printf("\t\tlo := uint%d(0)\n", usize(len(values))) g.Printf("\t\tlo := uint%d(0)\n", usize(len(values)))
g.Printf("\t\tif i > 0 {\n") g.Printf("\t\tif i > 0 {\n")
g.Printf("\t\t\tlo = _%s_index_%d[i-1]\n", typeName, i) g.Printf("\t\t\tlo = _%s_index_%d[i-1]\n", typeName, i)