From cd2ed857af9b4c9b1ce2aeb39b18973117f8ea28 Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Wed, 26 Jun 2019 15:24:04 -0400 Subject: [PATCH] internal/lsp: fix panic in computing file version Fixes golang/go#32791 Change-Id: I04fc3de5ed94137424a32f3e7200ba72d3913329 Reviewed-on: https://go-review.googlesource.com/c/tools/+/183984 Run-TryBot: Rebecca Stambler Reviewed-by: Michael Matloob --- internal/lsp/cache/external.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/internal/lsp/cache/external.go b/internal/lsp/cache/external.go index 043d20ac..ddb73675 100644 --- a/internal/lsp/cache/external.go +++ b/internal/lsp/cache/external.go @@ -23,12 +23,10 @@ type nativeFileHandle struct { } func (fs *nativeFileSystem) GetFile(uri span.URI) source.FileHandle { - var version string - fi, err := os.Stat(uri.Filename()) - if err != nil { - version = "DOES NOT EXIST" + version := "DOES NOT EXIST" + if fi, err := os.Stat(uri.Filename()); err == nil { + version = fi.ModTime().String() } - version = fi.ModTime().String() return &nativeFileHandle{ fs: fs, identity: source.FileIdentity{