From cccd43354a94cc5c2d3178355fbfe9b7a2db03c1 Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Thu, 2 Oct 2014 10:33:35 -0700 Subject: [PATCH] cmd/vet: fix bug where incorrect exit code was returned Fixes golang/go#8792. This is a simple change that fixes the issue. It may be desireable to opt for a larger code change that makes this problem less likely to be inadvertedly reintroduced in the future. For instance, a vetMain() func can be used similar to gofmtMain(), or the os.Exit call can be deferred. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/150850043 --- cmd/vet/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/vet/main.go b/cmd/vet/main.go index 0b74090c..622acb7b 100644 --- a/cmd/vet/main.go +++ b/cmd/vet/main.go @@ -245,7 +245,7 @@ func main() { for _, name := range flag.Args() { walkDir(name) } - return + os.Exit(exitCode) } if !doPackage(".", flag.Args()) { warnf("no files checked")