From c1406c36efe20fb423f43a73518f0454febeed1f Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Mon, 20 Aug 2018 16:53:32 -0400 Subject: [PATCH] go/packages: fix test failing on go1.10 The legacy implementation currently always loads from source code, so packages are more complete than expected. Change-Id: Ib8c9f7ac590038108dba05c1f47d22e70734945c Reviewed-on: https://go-review.googlesource.com/130095 Reviewed-by: Michael Matloob --- go/packages/packages_test.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/go/packages/packages_test.go b/go/packages/packages_test.go index db2449d5..b2e15bac 100644 --- a/go/packages/packages_test.go +++ b/go/packages/packages_test.go @@ -665,10 +665,6 @@ func TestLoadSyntaxOK(t *testing.T) { t.Errorf("wrong import graph: got <<%s>>, want <<%s>>", graph, wantGraph) } - // TODO(matloob): The legacy go list based support loads everything from source - // because it doesn't do a build and the .a files don't exist. - // Can we simulate its existence? - for _, test := range []struct { id string wantSyntax bool @@ -681,8 +677,12 @@ func TestLoadSyntaxOK(t *testing.T) { {"e", false, false}, // export data package {"f", false, false}, // export data package } { - if usesOldGolist && !test.wantSyntax { - // legacy go list always upgrades to LoadAllSyntax, syntax will be filled in. + // TODO(matloob): The legacy go list based support loads + // everything from source because it doesn't do a build + // and the .a files don't exist. + // Can we simulate its existence? + if usesOldGolist { + test.wantComplete = true test.wantSyntax = true } p := all[test.id]