From 9947fec5c3ab2e0e52fb2890e20ab960eed216c2 Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Thu, 27 Jun 2019 13:28:40 -0400 Subject: [PATCH] internal/lsp: modify check for a missing package Trying again. Apparently it's useful to run tests before submitting code. Change-Id: I487ffd391663cba47d2b26e8346cc7ac589dcd1a Reviewed-on: https://go-review.googlesource.com/c/tools/+/184041 Run-TryBot: Rebecca Stambler Reviewed-by: Suzy Mueller TryBot-Result: Gobot Gobot --- internal/lsp/cache/load.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/lsp/cache/load.go b/internal/lsp/cache/load.go index 913ef4a3..789784da 100644 --- a/internal/lsp/cache/load.go +++ b/internal/lsp/cache/load.go @@ -118,7 +118,8 @@ func (v *view) checkMetadata(ctx context.Context, f *goFile) (map[packageID]*met return nil, pkg.Errors, fmt.Errorf("package %s has errors, skipping type-checking", pkg.PkgPath) } for importPath, importPkg := range pkg.Imports { - if len(importPkg.Errors) > 0 { + // If we encounter a package we cannot import, mark it as missing. + if importPkg.PkgPath != "unsafe" && len(importPkg.CompiledGoFiles) == 0 { if f.missingImports == nil { f.missingImports = make(map[packagePath]struct{}) }