From 9531aca448eb5137b7a86a3117fc4b100cc58117 Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Tue, 15 Apr 2014 15:41:02 -0400 Subject: [PATCH] go.tools/go/pointer: add TODO comment. LGTM=gri R=gri CC=golang-codereviews https://golang.org/cl/87810046 --- go/pointer/analysis.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/go/pointer/analysis.go b/go/pointer/analysis.go index 42deb0bf..699462ba 100644 --- a/go/pointer/analysis.go +++ b/go/pointer/analysis.go @@ -322,6 +322,10 @@ func (a *analysis) callEdge(caller *cgnode, site *callsite, calleeid nodeid) { callee := obj.cgn if cg := a.result.CallGraph; cg != nil { + // TODO(adonovan): opt: I would expect duplicate edges + // (to wrappers) to arise due to the elimination of + // context information, but I haven't observed any. + // Understand this better. callgraph.AddEdge(cg.CreateNode(caller.fn), site.instr, cg.CreateNode(callee.fn)) }