From 86483bace61a0658d207b92f8ed38e06b386a5cb Mon Sep 17 00:00:00 2001 From: Michael Matloob Date: Thu, 21 Mar 2019 13:02:52 -0400 Subject: [PATCH] go/packages: make error message for conflicting packages more clear Make it slightly more clear that this is not a user error, but an internal error. Updates golang/go#30519 Change-Id: I7adb3b5bb1548eab8e46db48946d55f9d59a4311 Reviewed-on: https://go-review.googlesource.com/c/tools/+/168657 Run-TryBot: Michael Matloob Reviewed-by: Ian Cottrell --- go/packages/golist.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/packages/golist.go b/go/packages/golist.go index 560d3e3f..ff889ffb 100644 --- a/go/packages/golist.go +++ b/go/packages/golist.go @@ -586,7 +586,7 @@ func golistDriverCurrent(cfg *Config, words ...string) (*driverResponse, error) if old, found := seen[p.ImportPath]; found { if !reflect.DeepEqual(p, old) { - return nil, fmt.Errorf("go list repeated package %v with different values", p.ImportPath) + return nil, fmt.Errorf("internal error: go list gives conflicting information for package ", p.ImportPath) } // skip the duplicate continue