close_issue_2
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dashboard: fix perf graph view 

1. Add missing comma to empty records after addition of Ann column.
2. Fix off-by-one in commit range calculation.
Release tags refer to the last commit of the release,
so there is no need to subtract 1 from them.

TBR=adg
R=adg, bradfitz
CC=golang-codereviews
https://golang.org/cl/157120043
This commit is contained in:
Dmitriy Vyukov 2014-10-18 14:39:02 +04:00
parent e2b4e09ae1
commit 78ab88e721
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dashboard/app/build/perf_graph.go
View File

@ -71,7 +71,7 @@ func perfGraphHandler(w http.ResponseWriter, r *http.Request) {
logErr(w, r, err) logErr(w, r, err)
return return
} }
startCommitNum = comFrom.Num - 1 startCommitNum = comFrom.Num
retry: retry:
if commitTo == "tip" { if commitTo == "tip" {
@ -87,7 +87,7 @@ func perfGraphHandler(w http.ResponseWriter, r *http.Request) {
logErr(w, r, err) logErr(w, r, err)
return return
} }
endCommitNum = comTo.Num endCommitNum = comTo.Num + 1
} }
if endCommitNum <= startCommitNum { if endCommitNum <= startCommitNum {
// User probably selected from:go1.3 to:go1.2. Fix go1.2 to tip. // User probably selected from:go1.3 to:go1.2. Fix go1.2 to tip.

2
dashboard/app/build/perf_graph.html
View File

@ -29,7 +29,7 @@
{{if .Val}} {{if .Val}}
{{.Val}}, {{.Certainty}}, '{{.Hint}}', '{{.Ann}}', {{.Val}}, {{.Certainty}}, '{{.Hint}}', '{{.Ann}}',
{{else}} {{else}}
,,, ,,,,
{{end}} {{end}}
{{end}} {{end}}
], ],