go.tools/go/buildutil: AllPackages: enumerate all packages in a Go workspace.
This function has been copied at least 6 times throughout go.tools. This implementation is superior since it does all I/O through the virtualized go/build file system, and it is highly parallel (and much faster). We expose two flavours, simple (for existing tests) and parallel (for high-performance tools such as gorename). This CL creates the go/buildutil package, which is intended for utilities related to go/build. + test. LGTM=gri R=gri CC=golang-codereviews https://golang.org/cl/137430043
This commit is contained in:
parent
e548cb3dfe
commit
77b9ff6df3
|
|
@ -0,0 +1,108 @@
|
||||||
|
// Copyright 2014 The Go Authors. All rights reserved.
|
||||||
|
// Use of this source code is governed by a BSD-style
|
||||||
|
// license that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
// Package buildutil provides utilities related to the go/build
|
||||||
|
// package in the standard library.
|
||||||
|
package buildutil
|
||||||
|
|
||||||
|
import (
|
||||||
|
"go/build"
|
||||||
|
"io/ioutil"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
"sort"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
)
|
||||||
|
|
||||||
|
// AllPackagesList returns the import path of each Go package in any source
|
||||||
|
// directory of the specified build context (e.g. $GOROOT or an element
|
||||||
|
// of $GOPATH). Errors are ignored. The results are sorted.
|
||||||
|
//
|
||||||
|
// The result may include import paths for directories that contain no
|
||||||
|
// *.go files, such as "archive" (in $GOROOT/src).
|
||||||
|
//
|
||||||
|
// All I/O is via the build.Context virtual file system,
|
||||||
|
// which must be concurrency-safe.
|
||||||
|
//
|
||||||
|
func AllPackagesList(ctxt *build.Context) []string {
|
||||||
|
var list []string
|
||||||
|
var mu sync.Mutex
|
||||||
|
AllPackages(ctxt, func(pkg string, _ error) {
|
||||||
|
mu.Lock()
|
||||||
|
list = append(list, pkg)
|
||||||
|
mu.Unlock()
|
||||||
|
})
|
||||||
|
sort.Strings(list)
|
||||||
|
return list
|
||||||
|
}
|
||||||
|
|
||||||
|
// AllPackages calls the found function with the import path of
|
||||||
|
// each Go package it finds in any source directory of the specified
|
||||||
|
// build context (e.g. $GOROOT or an element of $GOPATH).
|
||||||
|
//
|
||||||
|
// If the package directory exists but could not be read, the second
|
||||||
|
// argument to the found function provides the error.
|
||||||
|
//
|
||||||
|
// The found function and the build.Context virtual file system
|
||||||
|
// accessors must be concurrency safe.
|
||||||
|
//
|
||||||
|
func AllPackages(ctxt *build.Context, found func(importPath string, err error)) {
|
||||||
|
var wg sync.WaitGroup
|
||||||
|
for _, root := range ctxt.SrcDirs() {
|
||||||
|
root := root
|
||||||
|
wg.Add(1)
|
||||||
|
go func() {
|
||||||
|
allPackages(ctxt, root, found)
|
||||||
|
wg.Done()
|
||||||
|
}()
|
||||||
|
}
|
||||||
|
wg.Wait()
|
||||||
|
}
|
||||||
|
|
||||||
|
func allPackages(ctxt *build.Context, root string, found func(string, error)) {
|
||||||
|
ReadDir := ctxt.ReadDir
|
||||||
|
if ReadDir == nil {
|
||||||
|
ReadDir = ioutil.ReadDir
|
||||||
|
}
|
||||||
|
|
||||||
|
root = filepath.Clean(root) + string(os.PathSeparator)
|
||||||
|
|
||||||
|
var wg sync.WaitGroup
|
||||||
|
|
||||||
|
var walkDir func(dir string)
|
||||||
|
walkDir = func(dir string) {
|
||||||
|
// Prune search if we encounter any directory with these base names:
|
||||||
|
switch filepath.Base(dir) {
|
||||||
|
case "testdata", ".hg":
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
pkg := filepath.ToSlash(strings.TrimPrefix(dir, root))
|
||||||
|
|
||||||
|
// Prune search if we encounter any of these import paths.
|
||||||
|
switch pkg {
|
||||||
|
case "builtin":
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
files, err := ReadDir(dir)
|
||||||
|
if pkg != "" || err != nil {
|
||||||
|
found(pkg, err)
|
||||||
|
}
|
||||||
|
for _, fi := range files {
|
||||||
|
fi := fi
|
||||||
|
if fi.IsDir() {
|
||||||
|
wg.Add(1)
|
||||||
|
go func() {
|
||||||
|
walkDir(filepath.Join(dir, fi.Name()))
|
||||||
|
wg.Done()
|
||||||
|
}()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
walkDir(root)
|
||||||
|
wg.Wait()
|
||||||
|
}
|
||||||
|
|
@ -0,0 +1,32 @@
|
||||||
|
// Copyright 2014 The Go Authors. All rights reserved.
|
||||||
|
// Use of this source code is governed by a BSD-style
|
||||||
|
// license that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
package buildutil_test
|
||||||
|
|
||||||
|
import (
|
||||||
|
"go/build"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"code.google.com/p/go.tools/go/buildutil"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestAllPackages(t *testing.T) {
|
||||||
|
all := buildutil.AllPackagesList(&build.Default)
|
||||||
|
|
||||||
|
set := make(map[string]bool)
|
||||||
|
for _, pkg := range all {
|
||||||
|
set[pkg] = true
|
||||||
|
}
|
||||||
|
|
||||||
|
const wantAtLeast = 250
|
||||||
|
if len(all) < wantAtLeast {
|
||||||
|
t.Errorf("Found only %d packages, want at least %d", len(all), wantAtLeast)
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, want := range []string{"fmt", "crypto/sha256", "code.google.com/p/go.tools/go/buildutil"} {
|
||||||
|
if !set[want] {
|
||||||
|
t.Errorf("Package %q not found; got %s", want, all)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
Loading…
Reference in New Issue