From 6fe81c087942f588f40c3f67b41ce284f2f70eee Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Sat, 20 Oct 2018 01:03:24 -0400 Subject: [PATCH] present: remove mention of non-existing emphasis toggle To find out whether the documentation was wrong, or if the implementation had a bug, I did some code archeology. The earliest commit I found where the 'h' key in browser was mentioned was the very first commit where the present format is added. It was in talks subrepo before being moved to tools subrepo. It was CL 6497063. In that commit, I see no mention of 'h' key anywhere else except that one line of documentation. Three years later, the 'h' key got mapped to hiding the help dialog in CL 4910. My best guess is this original feature was documented but never implemented. So removing it from documentation is the most appropriate fix. Fixes golang/go#17375. Change-Id: Ibe0b39d73a7a0652acd6a04beddfcff22b0e3c4a Reviewed-on: https://go-review.googlesource.com/c/143557 Reviewed-by: Andrew Gerrand --- present/doc.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/present/doc.go b/present/doc.go index 4d276107..ff75d66c 100644 --- a/present/doc.go +++ b/present/doc.go @@ -138,9 +138,8 @@ and see only this: Also, inside the displayed text a line that ends // HL -will be highlighted in the display; the 'h' key in the browser will -toggle extra emphasis of any highlighted lines. A highlighting mark -may have a suffix word, such as +will be highlighted in the display. A highlighting mark may have a +suffix word, such as // HLxxx Such highlights are enabled only if the code invocation ends with "HL" followed by the word: