From 520acf2e17e380d794da2a17728250e4287a1862 Mon Sep 17 00:00:00 2001
From: Andrew Gerrand <adg@golang.org>
Date: Thu, 18 Sep 2014 18:07:02 +1000
Subject: [PATCH] go.tools/dashboard/app: don't ignore field mismatch errors

This was a hold-over from when we removed install counts years ago.
All the Package entities are well-formed these days.

LGTM=dsymonds
R=dsymonds
CC=golang-codereviews
https://golang.org/cl/138620043
---
 dashboard/app/build/build.go | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/dashboard/app/build/build.go b/dashboard/app/build/build.go
index dcb2ee88..42112ad6 100644
--- a/dashboard/app/build/build.go
+++ b/dashboard/app/build/build.go
@@ -59,10 +59,6 @@ func (p *Package) LastCommit(c appengine.Context) (*Commit, error) {
 		Order("-Time").
 		Limit(1).
 		GetAll(c, &commits)
-	if _, ok := err.(*datastore.ErrFieldMismatch); ok {
-		// Some fields have been removed, so it's okay to ignore this error.
-		err = nil
-	}
 	if err != nil {
 		return nil, err
 	}
@@ -79,10 +75,6 @@ func GetPackage(c appengine.Context, path string) (*Package, error) {
 	if err == datastore.ErrNoSuchEntity {
 		return nil, fmt.Errorf("package %q not found", path)
 	}
-	if _, ok := err.(*datastore.ErrFieldMismatch); ok {
-		// Some fields have been removed, so it's okay to ignore this error.
-		err = nil
-	}
 	return p, err
 }
 
@@ -827,10 +819,6 @@ func Packages(c appengine.Context, kind string) ([]*Package, error) {
 	for t := q.Run(c); ; {
 		pkg := new(Package)
 		_, err := t.Next(pkg)
-		if _, ok := err.(*datastore.ErrFieldMismatch); ok {
-			// Some fields have been removed, so it's okay to ignore this error.
-			err = nil
-		}
 		if err == datastore.Done {
 			break
 		} else if err != nil {