From 33176b2029f9538e722efa4a005f7aa00cf60010 Mon Sep 17 00:00:00 2001 From: Ian Cottrell Date: Tue, 31 Jul 2018 15:06:28 -0400 Subject: [PATCH] go/packages: make a test Errorf into Fatalf It is a bounds check on an array before an access, the test cannot continue safely if it fails, so it should be fatal. Change-Id: Icd081df9cb81d549519d69bd34739d950946ccf5 Reviewed-on: https://go-review.googlesource.com/126975 Run-TryBot: Ian Cottrell Reviewed-by: Brad Fitzpatrick Reviewed-by: Michael Matloob TryBot-Result: Gobot Gobot --- go/packages/packages_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/packages/packages_test.go b/go/packages/packages_test.go index 0d4780e7..9ad8b740 100644 --- a/go/packages/packages_test.go +++ b/go/packages/packages_test.go @@ -376,7 +376,7 @@ package b`, t.Error(err) } if len(initial) != 1 { - t.Errorf("test tags %v: pattern %s, expected 1 package, got %d packages.", test.tags, test.pattern, len(initial)) + t.Fatalf("test tags %v: pattern %s, expected 1 package, got %d packages.", test.tags, test.pattern, len(initial)) } pkg := initial[0] if srcs := strings.Join(srcs(pkg), " "); srcs != test.wantSrcs {