diff --git a/go/analysis/passes/vet/testdata/divergent/buf.go b/go/analysis/passes/tests/testdata/src/divergent/buf.go similarity index 100% rename from go/analysis/passes/vet/testdata/divergent/buf.go rename to go/analysis/passes/tests/testdata/src/divergent/buf.go diff --git a/go/analysis/passes/tests/testdata/src/divergent/buf_test.go b/go/analysis/passes/tests/testdata/src/divergent/buf_test.go new file mode 100644 index 00000000..7dfd4ef1 --- /dev/null +++ b/go/analysis/passes/tests/testdata/src/divergent/buf_test.go @@ -0,0 +1,35 @@ +// Test of examples with divergent packages. + +package buf + +func Example() {} // OK because is package-level. + +func Example_suffix() {} // OK because refers to suffix annotation. + +func Example_BadSuffix() {} // want "Example_BadSuffix has malformed example suffix: BadSuffix" + +func ExampleBuf() {} // OK because refers to known top-level type. + +func ExampleBuf_Append() {} // OK because refers to known method. + +func ExampleBuf_Clear() {} // want "ExampleBuf_Clear refers to unknown field or method: Buf.Clear" + +func ExampleBuf_suffix() {} // OK because refers to suffix annotation. + +func ExampleBuf_Append_Bad() {} // want "ExampleBuf_Append_Bad has malformed example suffix: Bad" + +func ExampleBuf_Append_suffix() {} // OK because refers to known method with valid suffix. + +func ExampleDefaultBuf() {} // OK because refers to top-level identifier. + +func ExampleBuf_Reset() bool { return true } // want "ExampleBuf_Reset should return nothing" + +func ExampleBuf_Len(i int) {} // want "ExampleBuf_Len should be niladic" + +// "Puffer" is German for "Buffer". + +func ExamplePuffer() {} // want "ExamplePuffer refers to unknown identifier: Puffer" + +func ExamplePuffer_Append() {} // want "ExamplePuffer_Append refers to unknown identifier: Puffer" + +func ExamplePuffer_suffix() {} // want "ExamplePuffer_suffix refers to unknown identifier: Puffer" diff --git a/go/analysis/passes/tests/tests_test.go b/go/analysis/passes/tests/tests_test.go index 172ae8ef..53296485 100644 --- a/go/analysis/passes/tests/tests_test.go +++ b/go/analysis/passes/tests/tests_test.go @@ -13,6 +13,9 @@ import ( func Test(t *testing.T) { testdata := analysistest.TestData() - // Loads "a", "a [a.test]", and "a.test". - analysistest.Run(t, testdata, tests.Analyzer, "a") + + analysistest.Run(t, testdata, tests.Analyzer, + "a", // loads "a", "a [a.test]", and "a.test" + "divergent", + ) } diff --git a/go/analysis/passes/vet/testdata/divergent/buf_test.go b/go/analysis/passes/vet/testdata/divergent/buf_test.go deleted file mode 100644 index b75d55ea..00000000 --- a/go/analysis/passes/vet/testdata/divergent/buf_test.go +++ /dev/null @@ -1,35 +0,0 @@ -// Test of examples with divergent packages. - -package buf_test - -func Example() {} // OK because is package-level. - -func Example_suffix() {} // OK because refers to suffix annotation. - -func Example_BadSuffix() {} // ERROR "Example_BadSuffix has malformed example suffix: BadSuffix" - -func ExampleBuf() {} // OK because refers to known top-level type. - -func ExampleBuf_Append() {} // OK because refers to known method. - -func ExampleBuf_Clear() {} // ERROR "ExampleBuf_Clear refers to unknown field or method: Buf.Clear" - -func ExampleBuf_suffix() {} // OK because refers to suffix annotation. - -func ExampleBuf_Append_Bad() {} // ERROR "ExampleBuf_Append_Bad has malformed example suffix: Bad" - -func ExampleBuf_Append_suffix() {} // OK because refers to known method with valid suffix. - -func ExampleDefaultBuf() {} // OK because refers to top-level identifier. - -func ExampleBuf_Reset() bool { return true } // ERROR "ExampleBuf_Reset should return nothing" - -func ExampleBuf_Len(i int) {} // ERROR "ExampleBuf_Len should be niladic" - -// "Puffer" is German for "Buffer". - -func ExamplePuffer() {} // ERROR "ExamplePuffer refers to unknown identifier: Puffer" - -func ExamplePuffer_Append() {} // ERROR "ExamplePuffer_Append refers to unknown identifier: Puffer" - -func ExamplePuffer_suffix() {} // ERROR "ExamplePuffer_suffix refers to unknown identifier: Puffer" diff --git a/go/analysis/passes/vet/testdata/incomplete/examples_test.go b/go/analysis/passes/vet/testdata/incomplete/examples_test.go deleted file mode 100644 index 445502b3..00000000 --- a/go/analysis/passes/vet/testdata/incomplete/examples_test.go +++ /dev/null @@ -1,33 +0,0 @@ -// Test of examples. - -package testdata - -func Example() {} // OK because is package-level. - -func Example_suffix() // OK because refers to suffix annotation. - -func Example_BadSuffix() // OK because non-test package was excluded. No false positives wanted. - -func ExampleBuf() // OK because non-test package was excluded. No false positives wanted. - -func ExampleBuf_Append() {} // OK because non-test package was excluded. No false positives wanted. - -func ExampleBuf_Clear() {} // OK because non-test package was excluded. No false positives wanted. - -func ExampleBuf_suffix() {} // OK because refers to suffix annotation. - -func ExampleBuf_Append_Bad() {} // OK because non-test package was excluded. No false positives wanted. - -func ExampleBuf_Append_suffix() {} // OK because refers to known method with valid suffix. - -func ExampleBuf_Reset() bool { return true } // ERROR "ExampleBuf_Reset should return nothing" - -func ExampleBuf_Len(i int) {} // ERROR "ExampleBuf_Len should be niladic" - -// "Puffer" is German for "Buffer". - -func ExamplePuffer() // OK because non-test package was excluded. No false positives wanted. - -func ExamplePuffer_Append() // OK because non-test package was excluded. No false positives wanted. - -func ExamplePuffer_suffix() // OK because non-test package was excluded. No false positives wanted.